From: Ben Pfaff <blp@cs.stanford.edu>
Date: Tue, 25 Sep 2012 22:51:07 +0000 (-0700)
Subject: EXAMINE: Avoid useless call to casereader_count_cases().
X-Git-Url: https://pintos-os.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b05cde73f4291705bba140d6ef9896a11616f3ff;p=pspp

EXAMINE: Avoid useless call to casereader_count_cases().

The return value is never used, and this call could have significant
expense (it could cause the data to be read an extra time), so do not
do it.

Reported by GCC 4.7.
---

diff --git a/src/language/stats/examine.c b/src/language/stats/examine.c
index 46b27f9d36..0d9c68585a 100644
--- a/src/language/stats/examine.c
+++ b/src/language/stats/examine.c
@@ -1596,7 +1596,6 @@ calculate_n (const void *aux1, void *aux2 UNUSED, void *user_data)
       double imax = es[v].cc;
       struct casereader *reader;
       struct ccase *c;
-      casenumber total_cases;
 
       if (examine->histogram)
         {
@@ -1610,7 +1609,6 @@ calculate_n (const void *aux1, void *aux2 UNUSED, void *user_data)
         }
 
       es[v].sorted_reader = casewriter_make_reader (es[v].sorted_writer);
-      total_cases = casereader_count_cases (es[v].sorted_reader);
       es[v].sorted_writer = NULL;
 
       es[v].maxima = pool_calloc (examine->pool, examine->calc_extremes, sizeof (*es[v].maxima));