From: Stefano Lattarini Date: Tue, 7 Jun 2011 11:27:00 +0000 (+0200) Subject: tests init: new function 'fatal_', for hard errors X-Git-Url: https://pintos-os.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=b0579989e503cdae02591aaf0320e250efe07fd9;p=pspp tests init: new function 'fatal_', for hard errors Before this patch, the only way offered by tests/init.sh to properly signal a hard error was the `framework_failure_' function. But the error message issued by that function, as its name would suggest, refers to a set-up failure in the testsuite, while hard errors can obviously also be due to other reasons. The best way to fix this inconsistency is to introduce a new function with a more general error message. * tests/init.sh (fatal_): New function. --- diff --git a/ChangeLog b/ChangeLog index 506a079bf1..c706c10711 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,15 @@ +2011-06-07 Stefano Lattarini + + tests init: new function 'fatal_', for hard errors + Before this patch, the only way offered by tests/init.sh to + properly signal a hard error was the `framework_failure_' + function. But the error message issued by that function, + as its name would suggest, refers to a set-up failure in the + testsuite, while hard errors can obviously also be due to + other reasons. The best way to fix this inconsistency is to + introduce a new function with a more general error message. + * tests/init.sh (fatal_): New function. + 2011-06-06 Eric Blake canonicalize-lgpl: use common idiom diff --git a/tests/init.sh b/tests/init.sh index 294dcdd0f6..b5379fa504 100644 --- a/tests/init.sh +++ b/tests/init.sh @@ -77,6 +77,7 @@ Exit () { set +e; (exit $1); exit $1; } warn_ () { echo "$@" 1>&$stderr_fileno_; } fail_ () { warn_ "$ME_: failed test: $@"; Exit 1; } skip_ () { warn_ "$ME_: skipped test: $@"; Exit 77; } +fatal_ () { warn_ "$ME_: hard error: $@"; Exit 99; } framework_failure_ () { warn_ "$ME_: set-up failure: $@"; Exit 99; } # Sanitize this shell to POSIX mode, if possible.