From: Bruno Haible Date: Tue, 14 Jan 2003 12:38:51 +0000 (+0000) Subject: Add comment about low quality of this function. X-Git-Url: https://pintos-os.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ab352daed97372060cc038c30f2b6394d8ff1c54;p=pspp Add comment about low quality of this function. --- diff --git a/lib/ChangeLog b/lib/ChangeLog index 581842c841..e9e298133a 100644 --- a/lib/ChangeLog +++ b/lib/ChangeLog @@ -1,3 +1,7 @@ +2003-01-11 Bruno Haible + + * hash-pjw.c: Add comment about low quality of this function. + 2003-01-12 Paul Eggert Finish renaming getstr -> getdelim2 and readline -> readlinebuffer, diff --git a/lib/hash-pjw.c b/lib/hash-pjw.c index 141b08b51f..0a14b3e7af 100644 --- a/lib/hash-pjw.c +++ b/lib/hash-pjw.c @@ -1,5 +1,5 @@ /* hash-pjw.c -- compute a hash value from a NUL-terminated string. - Copyright 2001 Free Software Foundation, Inc. + Copyright 2001, 2003 Free Software Foundation, Inc. This program is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by @@ -22,7 +22,10 @@ #include "hash-pjw.h" /* A hash function for NUL-terminated char* strings using - the method described in Aho, Sethi, & Ullman, p 436. */ + the method described in Aho, Sethi, & Ullman, p 436. + Note that this hash function produces a lot of collisions when used + with short strings with very varied bit patterns. + See http://www.haible.de/bruno/hashfunc.html. */ unsigned int hash_pjw (const void *x, unsigned int tablesize)