From: Ben Pfaff <blp@nicira.com>
Date: Fri, 25 Feb 2011 01:03:28 +0000 (-0800)
Subject: ofproto: Log warning if controller requests an invalid table.
X-Git-Url: https://pintos-os.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=a02e5331f6064a7b9dd11f1091ab9fcb1bbdadcc;p=openvswitch

ofproto: Log warning if controller requests an invalid table.

This might have saved us some time debugging.
---

diff --git a/ofproto/ofproto.c b/ofproto/ofproto.c
index 61d08ea4..2efb03af 100644
--- a/ofproto/ofproto.c
+++ b/ofproto/ofproto.c
@@ -3543,7 +3543,16 @@ put_ofp_flow_stats(struct ofconn *ofconn, struct rule *rule,
 static bool
 is_valid_table(uint8_t table_id)
 {
-    return table_id == 0 || table_id == 0xff;
+    if (table_id == 0 || table_id == 0xff) {
+        return true;
+    } else {
+        /* It would probably be better to reply with an error but there doesn't
+         * seem to be any appropriate value, so that might just be
+         * confusing. */
+        VLOG_WARN_RL(&rl, "controller asked for invalid table %"PRIu8,
+                     table_id);
+        return false;
+    }
 }
 
 static int