From: Ethan Jackson <ethan@nicira.com>
Date: Tue, 16 Aug 2011 21:16:58 +0000 (-0700)
Subject: ofproto: Fix over accounting of byte counters.
X-Git-Url: https://pintos-os.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=9adea03b888b0087cdd5877f61ed6a50170ea8f7;p=openvswitch

ofproto: Fix over accounting of byte counters.

The update_stats() function in ofproto was attributing more bytes
to facets than they had actually accrued.  This could potentially
throw off bond load balancing.

Found by inspection.
---

diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c
index fdd20571..3aa0e786 100644
--- a/ofproto/ofproto-dpif.c
+++ b/ofproto/ofproto-dpif.c
@@ -1849,7 +1849,7 @@ update_stats(struct ofproto_dpif *p)
             facet->dp_byte_count = stats->n_bytes;
 
             facet_update_time(p, facet, stats->used);
-            facet_account(p, facet, stats->n_bytes);
+            facet_account(p, facet, 0);
             facet_push_stats(facet);
         } else {
             /* There's a flow in the datapath that we know nothing about.