From: Justin Pettit <jpettit@nicira.com>
Date: Tue, 17 Nov 2009 01:51:31 +0000 (-0800)
Subject: datapath: Calculate proper checksum for set_tp_src/dst action
X-Git-Url: https://pintos-os.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=985224ac0c6a2eeebf71c58b12893eafe2386a3d;p=openvswitch

datapath: Calculate proper checksum for set_tp_src/dst action

When the set_tp_src or set_tp_dst action is used, the calculation for
where the checksum is located was wrong.  This caused the checksum to
not be updated and packet corruption in the bad offset.
---

diff --git a/datapath/actions.c b/datapath/actions.c
index 8a3e8abb..a21bce84 100644
--- a/datapath/actions.c
+++ b/datapath/actions.c
@@ -259,8 +259,8 @@ set_tp_port(struct sk_buff *skb, struct odp_flow_key *key,
 		u16 *f = a->type == ODPAT_SET_TP_SRC ? &th->source : &th->dest;
 		u16 old = *f;
 		u16 new = a->tp_port;
-		update_csum((u16*)((u8*)skb->data + check_ofs),
-			    skb, old, new, 1);
+		update_csum((u16*)(skb_transport_header(skb) + check_ofs), 
+				skb, old, new, 1);
 		*f = new;
 	}
 	return skb;