From: Ben Pfaff Date: Tue, 11 Nov 2008 23:48:08 +0000 (-0800) Subject: Add comment. X-Git-Url: https://pintos-os.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=9171f241601286b36cce9d94580096cbc314783d;p=openvswitch Add comment. --- diff --git a/datapath/nx_act_snat.c b/datapath/nx_act_snat.c index 8bf2ed71..e577c9d4 100644 --- a/datapath/nx_act_snat.c +++ b/datapath/nx_act_snat.c @@ -399,6 +399,9 @@ snat_skb(struct datapath *dp, const struct sk_buff *skb, int out_port) if (!p) return; + /* FIXME: Expensive. Just need to skb_clone() here? + * (However, the skb_copy() does linearize and ensure that the headers + * are accessible.) */ nskb = skb_copy(skb, GFP_ATOMIC); if (!nskb) return;