From: Ben Pfaff <blp@cs.stanford.edu>
Date: Mon, 30 Sep 2013 07:12:35 +0000 (-0700)
Subject: variable: Complete renaming of ROLE_OUTPUT to ROLE_TARGET.
X-Git-Url: https://pintos-os.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=85f542c58c39fc4cff02d8914fd9c2af4c3dc9ef;p=pspp

variable: Complete renaming of ROLE_OUTPUT to ROLE_TARGET.

Commit 47d59628a7d51a (psppire-var-sheet: Rename references to the icons
for align, measure and role icons) renamed some but not all uses of
ROLE_OUTPUT, breaking the build.  This commit completes the rename.

According to Bastián Díaz, "target" is better than "output" because it
is "a broader concept for function".
---

diff --git a/src/data/sys-file-reader.c b/src/data/sys-file-reader.c
index 5949ee209c..d553b3a0e5 100644
--- a/src/data/sys-file-reader.c
+++ b/src/data/sys-file-reader.c
@@ -1958,7 +1958,7 @@ assign_variable_roles (struct sfm_reader *r, struct dictionary *dict)
               break;
 
             case 1:
-              role = ROLE_OUTPUT;
+              role = ROLE_TARGET;
               break;
 
             case 2:
diff --git a/src/data/sys-file-writer.c b/src/data/sys-file-writer.c
index 32326e13f2..4cf5c0893a 100644
--- a/src/data/sys-file-writer.c
+++ b/src/data/sys-file-writer.c
@@ -706,7 +706,7 @@ add_role_attribute (enum var_role role, struct attrset *attrs)
       s = "0";
       break;
 
-    case ROLE_OUTPUT:
+    case ROLE_TARGET:
       s = "1";
       break;
 
diff --git a/src/data/variable.c b/src/data/variable.c
index 72dd2d8ef6..c4bab00fc3 100644
--- a/src/data/variable.c
+++ b/src/data/variable.c
@@ -892,7 +892,7 @@ var_role_is_valid (enum var_role role)
     {
     case ROLE_NONE:
     case ROLE_INPUT:
-    case ROLE_OUTPUT:
+    case ROLE_TARGET:
     case ROLE_BOTH:
     case ROLE_PARTITION:
     case ROLE_SPLIT:
@@ -912,7 +912,7 @@ var_role_to_string (enum var_role role)
     case ROLE_INPUT:
       return _("Input");
 
-    case ROLE_OUTPUT:
+    case ROLE_TARGET:
       return _("Output");
 
     case ROLE_BOTH:
@@ -941,7 +941,7 @@ var_role_to_syntax (enum var_role role)
     case ROLE_INPUT:
       return "INPUT";
 
-    case ROLE_OUTPUT:
+    case ROLE_TARGET:
       return "TARGET";
 
     case ROLE_BOTH:
diff --git a/src/data/variable.h b/src/data/variable.h
index 3210a78f9a..d77a289afa 100644
--- a/src/data/variable.h
+++ b/src/data/variable.h
@@ -146,7 +146,7 @@ enum measure var_default_measure (enum val_type);
 enum var_role
   {
     ROLE_INPUT,
-    ROLE_OUTPUT,
+    ROLE_TARGET,
     ROLE_BOTH,
     ROLE_NONE,
     ROLE_PARTITION,
diff --git a/src/language/dictionary/variable-display.c b/src/language/dictionary/variable-display.c
index 63bc6d472c..67c2e13d63 100644
--- a/src/language/dictionary/variable-display.c
+++ b/src/language/dictionary/variable-display.c
@@ -198,7 +198,7 @@ cmd_variable_role (struct lexer *lexer, struct dataset *ds)
       if ( lex_match_id (lexer, "INPUT"))
         role = ROLE_INPUT;
       else if ( lex_match_id (lexer, "TARGET"))
-        role = ROLE_OUTPUT;
+        role = ROLE_TARGET;
       else if ( lex_match_id (lexer, "BOTH"))
         role = ROLE_BOTH;
       else if ( lex_match_id (lexer, "NONE"))