From: Ben Pfaff Date: Tue, 7 Dec 2010 18:49:47 +0000 (-0800) Subject: netlink: Add macros for iterating through attributes. X-Git-Url: https://pintos-os.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=7f8ca6459c37ede8faf13f730bcd4d9f05dfd13b;p=openvswitch netlink: Add macros for iterating through attributes. Acked-by: Jesse Gross --- diff --git a/lib/netlink.h b/lib/netlink.h index 77360fef..383681c3 100644 --- a/lib/netlink.h +++ b/lib/netlink.h @@ -34,6 +34,8 @@ #include #include #include +#include "netlink-protocol.h" +#include "openvswitch/types.h" struct ofpbuf; struct nlattr; @@ -89,6 +91,36 @@ enum nl_attr_type N_NL_ATTR_TYPES }; +/* Netlink attribute iteration. */ +static inline struct nlattr * +nl_attr_next(const struct nlattr *nla) +{ + return (struct nlattr *) ((uint8_t *) nla + NLA_ALIGN(nla->nla_len)); +} + +static inline bool +nl_attr_is_valid(const struct nlattr *nla, size_t maxlen) +{ + return (maxlen >= sizeof *nla + && nla->nla_len >= sizeof *nla + && NLA_ALIGN(nla->nla_len) <= maxlen); +} + +/* This macro is careful to check for attributes with bad lengths. */ +#define NL_ATTR_FOR_EACH(ITER, LEFT, ATTRS, ATTRS_LEN) \ + for ((ITER) = (ATTRS), (LEFT) = (ATTRS_LEN); \ + nl_attr_is_valid(ITER, LEFT); \ + (LEFT) -= NLA_ALIGN((ITER)->nla_len), (ITER) = nl_attr_next(ITER)) + + +/* This macro does not check for attributes with bad lengths. It should only + * be used with messages from trusted sources or with messages that have + * already been validates (e.g. with NL_ATTR_FOR_EACH). */ +#define NL_ATTR_FOR_EACH_UNSAFE(ITER, LEFT, ATTRS, ATTRS_LEN) \ + for ((ITER) = (ATTRS), (LEFT) = (ATTRS_LEN); \ + (LEFT) > 0; \ + (LEFT) -= NLA_ALIGN((ITER)->nla_len), (ITER) = nl_attr_next(ITER)) + /* Netlink attribute parsing. */ int nl_attr_type(const struct nlattr *); const void *nl_attr_get(const struct nlattr *);