From: John Darrington Date: Wed, 11 Jan 2012 21:04:14 +0000 (+0100) Subject: Use idle callback to write to the local config directory X-Git-Tag: v0.7.9~40 X-Git-Url: https://pintos-os.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=7a48928f76e0f4599be8f65b1b3bafd03d73a628;p=pspp-builds.git Use idle callback to write to the local config directory When the users config directory is on a filesystem with high latency, moving a dialog box resulted in many writes and thus an unacceptable delay. This change fixes that by consolidating the writes into a low priority idle callback. --- diff --git a/src/ui/gui/psppire-conf.c b/src/ui/gui/psppire-conf.c index 02cc2751..fe4f934b 100644 --- a/src/ui/gui/psppire-conf.c +++ b/src/ui/gui/psppire-conf.c @@ -24,6 +24,8 @@ #include #include +#include + #include "psppire-conf.h" static void psppire_conf_init (PsppireConf *conf); @@ -73,8 +75,8 @@ conf_read (PsppireConf *conf) NULL); } -static void -conf_write (PsppireConf *conf) +static gboolean +flush_conf (PsppireConf *conf) { gsize length = 0; @@ -86,8 +88,19 @@ conf_write (PsppireConf *conf) } g_free (kf); + conf->idle = 0; + return FALSE; } +static void +conf_write (PsppireConf *conf) +{ + if ( conf->idle == 0) + conf->idle = g_idle_add_full (G_PRIORITY_LOW, + (GSourceFunc) flush_conf, conf, NULL); +} + + static void psppire_conf_dispose (GObject *object) { @@ -157,6 +170,7 @@ psppire_conf_init (PsppireConf *conf) conf->keyfile = g_key_file_new (); conf->dispose_has_run = FALSE; + conf->idle = 0; } diff --git a/src/ui/gui/psppire-conf.h b/src/ui/gui/psppire-conf.h index 674577e7..85860226 100644 --- a/src/ui/gui/psppire-conf.h +++ b/src/ui/gui/psppire-conf.h @@ -62,6 +62,7 @@ struct _PsppireConf GKeyFile *keyfile; gchar *filename; + guint idle; };