From: Ben Pfaff <blp@cs.stanford.edu>
Date: Tue, 21 May 2013 05:20:18 +0000 (-0700)
Subject: REGRESSION: Avoid use-after-free error with TEMPORARY and SAVE.
X-Git-Url: https://pintos-os.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=6c15f78893f677ccdd45715640bf79961011d529;p=pspp

REGRESSION: Avoid use-after-free error with TEMPORARY and SAVE.

This should fix the use-after-free error, although I am not sure whether it
makes REGRESSION do exactly what it should do.

Bug #38787.
---

diff --git a/src/language/stats/regression.c b/src/language/stats/regression.c
index 282a252fdd..b63b28e876 100644
--- a/src/language/stats/regression.c
+++ b/src/language/stats/regression.c
@@ -388,6 +388,13 @@ cmd_regression (struct lexer *lexer, struct dataset *ds)
 
   regression.models = xcalloc (regression.n_dep_vars, sizeof *regression.models);
 
+  if (regression.pred || regression.resid)
+    {
+      if (proc_make_temporary_transformations_permanent (ds))
+        msg (SW, _("REGRESSION with SAVE ignores TEMPORARY.  "
+                   "Temporary transformations will be made permanent."));
+    }
+
   {
     struct casegrouper *grouper;
     struct casereader *group;