From: Jesse Gross Date: Fri, 20 Jan 2012 23:12:38 +0000 (-0800) Subject: datapath: Correct GRE checksum offset. X-Git-Url: https://pintos-os.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=69feaa6f1b37d6c6787f815b92a0ab65f5d8bbb4;p=openvswitch datapath: Correct GRE checksum offset. If a statically defined GRE key is used with checksums then the checksum will overwrite the key. This is because the key is set at header caching time and the checksum is set at packet processing time and we don't update the offset on packet processing because we don't do anything with the key. Reported-by: Christos Argyropoulos Signed-off-by: Jesse Gross --- diff --git a/datapath/vport-gre.c b/datapath/vport-gre.c index 4411cac9..eb100091 100644 --- a/datapath/vport-gre.c +++ b/datapath/vport-gre.c @@ -101,10 +101,11 @@ static struct sk_buff *gre_update_header(const struct vport *vport, - GRE_HEADER_SECTION); /* Work backwards over the options so the checksum is last. */ - if (mutable->flags & TNL_F_OUT_KEY_ACTION) { + if (mutable->flags & TNL_F_OUT_KEY_ACTION) *options = be64_get_low32(OVS_CB(skb)->tun_id); + + if (mutable->out_key || mutable->flags & TNL_F_OUT_KEY_ACTION) options--; - } if (mutable->flags & TNL_F_CSUM) *(__sum16 *)options = csum_fold(skb_checksum(skb,