From: Ben Pfaff <blp@nicira.com>
Date: Thu, 1 Jan 2009 18:09:32 +0000 (-0800)
Subject: brcompat: Remove unneeded RCU locking.
X-Git-Url: https://pintos-os.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=66a5e21cd1c0597e4e7916f9768c40d39463e247;p=openvswitch

brcompat: Remove unneeded RCU locking.

The only memory accessed here is in 'dev', which can't
disappear because we maintain a reference count on it.
net_devices aren't RCU-locked anyway.
---

diff --git a/datapath/brcompat.c b/datapath/brcompat.c
index 78c83edd..b0bbef6b 100644
--- a/datapath/brcompat.c
+++ b/datapath/brcompat.c
@@ -184,12 +184,10 @@ old_dev_ioctl(struct net_device *dev, struct ifreq *rq, int cmd)
 
 		memset(&b, 0, sizeof(struct __bridge_info));
 
-		rcu_read_lock();
 		for (i=0; i<ETH_ALEN; i++) 
 			id |= (uint64_t)dev->dev_addr[i] << (8*(ETH_ALEN-1 - i));
 		b.bridge_id = cpu_to_be64(id);
 		b.stp_enabled = 0;
-		rcu_read_unlock();
 
 		if (copy_to_user((void __user *)args[1], &b, sizeof(b)))
 			return -EFAULT;