From: Jesse Gross Date: Tue, 20 Sep 2011 23:29:38 +0000 (-0700) Subject: datapath: Send to userspace errors shouldn't halt processing. X-Git-Url: https://pintos-os.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=646b8753e467399966d1ed7bb56c81a84589029f;p=openvswitch datapath: Send to userspace errors shouldn't halt processing. If we encounter an error when sending a packet to userspace due to an explicit action we stop processing further actions. This makes sense for things like push vlan, where to continue means outputting an incorrect packet. However, sending to userspace is more akin to outputting to a port, which does not halt further processing. For consistency, ignore errors in this case as well. Signed-off-by: Jesse Gross Acked-by: Ben Pfaff --- diff --git a/datapath/actions.c b/datapath/actions.c index 83b531ad..deaa4dc9 100644 --- a/datapath/actions.c +++ b/datapath/actions.c @@ -290,7 +290,7 @@ static int do_execute_actions(struct datapath *dp, struct sk_buff *skb, break; case OVS_ACTION_ATTR_USERSPACE: - err = output_userspace(dp, skb, nla_get_u64(a)); + output_userspace(dp, skb, nla_get_u64(a)); break; case OVS_ACTION_ATTR_SET_TUNNEL: