From: Eric Blake Date: Thu, 4 Nov 2010 21:53:52 +0000 (-0600) Subject: ceil, floor, round, trunc: enhance tests of -0 X-Git-Url: https://pintos-os.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5dad7705e059bd0ce249a736b5af02dd66824ae0;p=pspp ceil, floor, round, trunc: enhance tests of -0 * tests/test-ceilf1.c (main): Ensure correct sign of result. * tests/test-ceill.c (main): Likewise. * tests/test-floorf1.c (main): Likewise. * tests/test-floorl.c (main): Likewise. * tests/test-round1.c (main): Likewise. * tests/test-roundf1.c (main): Likewise. * tests/test-roundl.c (main): Likewise. * tests/test-trunc1.c (main): Likewise. * tests/test-truncf1.c (main): Likewise. * tests/test-truncl.c (main): Likewise. Signed-off-by: Eric Blake --- diff --git a/ChangeLog b/ChangeLog index 3106ba7780..ea1a01f5eb 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,17 @@ +2010-11-04 Eric Blake + + ceil, floor, round, trunc: enhance tests of -0 + * tests/test-ceilf1.c (main): Ensure correct sign of result. + * tests/test-ceill.c (main): Likewise. + * tests/test-floorf1.c (main): Likewise. + * tests/test-floorl.c (main): Likewise. + * tests/test-round1.c (main): Likewise. + * tests/test-roundf1.c (main): Likewise. + * tests/test-roundl.c (main): Likewise. + * tests/test-trunc1.c (main): Likewise. + * tests/test-truncf1.c (main): Likewise. + * tests/test-truncl.c (main): Likewise. + 2010-11-04 Eric Blake frexp, tests: work around ICC bug with -zero diff --git a/modules/ceilf-tests b/modules/ceilf-tests index 040fd1bbf5..a0472a7c41 100644 --- a/modules/ceilf-tests +++ b/modules/ceilf-tests @@ -9,6 +9,7 @@ tests/macros.h Depends-on: float isnanf-nolibm +signbit stdbool stdint diff --git a/tests/test-ceilf1.c b/tests/test-ceilf1.c index 86bb49e00d..4e382476af 100644 --- a/tests/test-ceilf1.c +++ b/tests/test-ceilf1.c @@ -33,7 +33,9 @@ main () { /* Zero. */ ASSERT (ceilf (0.0f) == 0.0f); + ASSERT (!signbit (ceilf (0.0f))); ASSERT (ceilf (minus_zerof) == 0.0f); + ASSERT (!!signbit (minus_zerof) == !!signbit (ceilf (minus_zerof))); /* Positive numbers. */ ASSERT (ceilf (0.3f) == 1.0f); ASSERT (ceilf (0.7f) == 1.0f); diff --git a/tests/test-ceill.c b/tests/test-ceill.c index cac45b77f0..f627a9e299 100644 --- a/tests/test-ceill.c +++ b/tests/test-ceill.c @@ -40,7 +40,9 @@ main () /* Zero. */ ASSERT (ceill (0.0L) == 0.0L); + ASSERT (!signbit (ceill (0.0L))); ASSERT (ceill (minus_zerol) == 0.0L); + ASSERT (!!signbit (minus_zerol) == !!signbit (ceill (minus_zerol))); /* Positive numbers. */ ASSERT (ceill (0.3L) == 1.0L); ASSERT (ceill (0.7L) == 1.0L); diff --git a/tests/test-floorf1.c b/tests/test-floorf1.c index 39261d8057..f0f771624e 100644 --- a/tests/test-floorf1.c +++ b/tests/test-floorf1.c @@ -33,7 +33,9 @@ main () { /* Zero. */ ASSERT (floorf (0.0f) == 0.0f); + ASSERT (!signbit (floorf (0.0f))); ASSERT (floorf (minus_zerof) == 0.0f); + ASSERT (!!signbit (minus_zerof) == !!signbit (floorf (minus_zerof))); /* Positive numbers. */ ASSERT (floorf (0.3f) == 0.0f); ASSERT (floorf (0.7f) == 0.0f); diff --git a/tests/test-floorl.c b/tests/test-floorl.c index 84717f8beb..2675a9e5d5 100644 --- a/tests/test-floorl.c +++ b/tests/test-floorl.c @@ -40,7 +40,9 @@ main () /* Zero. */ ASSERT (floorl (0.0L) == 0.0L); + ASSERT (!signbit (floorl (0.0L))); ASSERT (floorl (minus_zerol) == 0.0L); + ASSERT (!!signbit (minus_zerol) == !!signbit (floorl (minus_zerol))); /* Positive numbers. */ ASSERT (floorl (0.3L) == 0.0L); ASSERT (floorl (0.7L) == 0.0L); diff --git a/tests/test-round1.c b/tests/test-round1.c index 86fd1de7ab..4711a74361 100644 --- a/tests/test-round1.c +++ b/tests/test-round1.c @@ -35,7 +35,9 @@ main () { /* Zero. */ ASSERT (round (0.0) == 0.0); + ASSERT (!signbit (round (0.0))); ASSERT (round (minus_zerod) == 0.0); + ASSERT (!!signbit (minus_zerod) == !!signbit (round (minus_zerod))); /* Positive numbers. */ ASSERT (round (0.3) == 0.0); ASSERT (round (0.5) == 1.0); diff --git a/tests/test-roundf1.c b/tests/test-roundf1.c index 33609bb6bd..354dcf02dc 100644 --- a/tests/test-roundf1.c +++ b/tests/test-roundf1.c @@ -35,7 +35,9 @@ main () { /* Zero. */ ASSERT (roundf (0.0f) == 0.0f); + ASSERT (!signbit (roundf (0.0f))); ASSERT (roundf (minus_zerof) == 0.0f); + ASSERT (!!signbit (minus_zerof) == !!signbit (roundf (minus_zerof))); /* Positive numbers. */ ASSERT (roundf (0.3f) == 0.0f); ASSERT (roundf (0.5f) == 1.0f); diff --git a/tests/test-roundl.c b/tests/test-roundl.c index f06db8a017..bdb8ddfec8 100644 --- a/tests/test-roundl.c +++ b/tests/test-roundl.c @@ -42,7 +42,9 @@ main () /* Zero. */ ASSERT (roundl (0.0L) == 0.0L); + ASSERT (!signbit (roundl (0.0L))); ASSERT (roundl (minus_zerol) == 0.0L); + ASSERT (!!signbit (minus_zerol) == !!signbit (roundl (minus_zerol))); /* Positive numbers. */ ASSERT (roundl (0.3L) == 0.0L); ASSERT (roundl (0.5L) == 1.0L); diff --git a/tests/test-trunc1.c b/tests/test-trunc1.c index 69530b8753..5587a41c0b 100644 --- a/tests/test-trunc1.c +++ b/tests/test-trunc1.c @@ -33,7 +33,9 @@ main () { /* Zero. */ ASSERT (trunc (0.0) == 0.0); + ASSERT (!signbit (trunc (0.0))); ASSERT (trunc (minus_zerod) == 0.0); + ASSERT (!!signbit (minus_zerod) == !!signbit (trunc (minus_zerod))); /* Positive numbers. */ ASSERT (trunc (0.3) == 0.0); ASSERT (trunc (0.7) == 0.0); diff --git a/tests/test-truncf1.c b/tests/test-truncf1.c index b5f48dd6ae..6953c8bbcf 100644 --- a/tests/test-truncf1.c +++ b/tests/test-truncf1.c @@ -33,7 +33,9 @@ main () { /* Zero. */ ASSERT (truncf (0.0f) == 0.0f); + ASSERT (!signbit (truncf (0.0f))); ASSERT (truncf (minus_zerof) == 0.0f); + ASSERT (!!signbit (minus_zerof) == !!signbit (truncf (minus_zerof))); /* Positive numbers. */ ASSERT (truncf (0.3f) == 0.0f); ASSERT (truncf (0.7f) == 0.0f); diff --git a/tests/test-truncl.c b/tests/test-truncl.c index ab1f4443f3..f2a9644eac 100644 --- a/tests/test-truncl.c +++ b/tests/test-truncl.c @@ -40,7 +40,9 @@ main () /* Zero. */ ASSERT (truncl (0.0L) == 0.0L); + ASSERT (!signbit (truncl (0.0L))); ASSERT (truncl (minus_zerol) == 0.0L); + ASSERT (!!signbit (minus_zerol) == !!signbit (truncl (minus_zerol))); /* Positive numbers. */ ASSERT (truncl (0.3L) == 0.0L); ASSERT (truncl (0.7L) == 0.0L);