From: Eric Blake Date: Wed, 10 Aug 2011 11:28:29 +0000 (-0600) Subject: closein: correct comments X-Git-Url: https://pintos-os.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5b9e0c3ce734b9d9b0c0001e31b65a8a4713700d;p=pspp closein: correct comments * lib/closein.c (close_stdin): Improve comments. Signed-off-by: Eric Blake --- diff --git a/ChangeLog b/ChangeLog index 701f07b536..538c121ab8 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,8 @@ +2011-08-10 Eric Blake + + closein: correct comments + * lib/closein.c (close_stdin): Improve comments. + 2011-08-09 Bruno Haible More tests for 'fseeko'. diff --git a/lib/closein.c b/lib/closein.c index beff8bb53a..2a652f4940 100644 --- a/lib/closein.c +++ b/lib/closein.c @@ -55,7 +55,7 @@ close_stdin_set_file_name (const char *file) For example, POSIX requires that these two commands behave alike: (sed -ne 1q; cat) < file - tail -n 1 file + tail -n +2 file Since close_stdin is commonly registered via 'atexit', POSIX and the C standard both say that it should not call 'exit', @@ -82,7 +82,8 @@ close_stdin (void) /* There is no need to flush stdin if we can determine quickly that stdin's input buffer is empty; in this case we know that if stdin is seekable, - fseeko (stdin, 0, SEEK_CUR) == lseek (0, 0, SEEK_CUR). */ + (fseeko (stdin, 0, SEEK_CUR), ftello (stdin)) + == lseek (0, 0, SEEK_CUR). */ if (freadahead (stdin) > 0) { /* Only attempt flush if stdin is seekable, as fflush is entitled to