From: Ben Pfaff Date: Thu, 7 Jan 2010 23:26:36 +0000 (-0800) Subject: vswitch: Fix types of NetFlow columns in db schema. X-Git-Url: https://pintos-os.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=58fbee4664788d779ad7b0e57c3dd420adca9221;p=openvswitch vswitch: Fix types of NetFlow columns in db schema. This bug was masked by the translation done by ovsdb-idlc, which doesn't fully validate its input. In particular, it ignores fields that it doesn't know about and drops them when it does translation, so nothing later can find the problem. An upcoming commit will ensure that it can't happen again, by dropping the ovsdb-idlc translation step. --- diff --git a/vswitchd/vswitch-idl.ovsidl b/vswitchd/vswitch-idl.ovsidl index 27804d42..128e8f1a 100644 --- a/vswitchd/vswitch-idl.ovsidl +++ b/vswitchd/vswitch-idl.ovsidl @@ -163,10 +163,10 @@ "type": {"key": "string", "min": 1, "max": "unlimited"}}, "engine_type": { "comment": "Engine type to use in NetFlow messages. Defaults to datapath index if not specified.", - "type": "integer", "min":0, "max":1}, + "type": {"key": "integer", "min": 0, "max": 1}}, "engine_id": { "comment": "Engine ID to use in NetFlow messages. Defaults to datapath index if not specified.", - "type": "integer", "min":0, "max":1}, + "type": {"key": "integer", "min": 0, "max": 1}}, "add_id_to_interface": { "comment": "Place least-significant 7 bits of engine ID into most significant bits of ingress and egress interface fields of NetFlow records?", "type": "boolean"},