From: Ben Pfaff Date: Mon, 11 Jan 2010 19:09:43 +0000 (-0800) Subject: sflow: Improve comments. X-Git-Url: https://pintos-os.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=46b47a4160c98adc6ee435f737a19da41e94d794;p=openvswitch sflow: Improve comments. Pointed out by Justin Pettit. --- diff --git a/ofproto/ofproto-sflow.c b/ofproto/ofproto-sflow.c index 1815dd9d..c1cc3171 100644 --- a/ofproto/ofproto-sflow.c +++ b/ofproto/ofproto-sflow.c @@ -421,7 +421,7 @@ ofproto_sflow_set_options(struct ofproto_sflow *os, sfl_receiver_set_sFlowRcvrOwner(receiver, "OpenVSwitch sFlow"); sfl_receiver_set_sFlowRcvrTimeout(receiver, 0xffffffff); - /* Add a single sampler to represent the whole switch (special :0 + /* Add a single sampler to represent the datapath (special :0 * datasource). The alternative is to model a physical switch more closely * and instantiate a separate sampler object for each interface, but then * unicasts would have to be offered to two samplers, and @@ -553,6 +553,9 @@ ofproto_sflow_received(struct ofproto_sflow *os, struct odp_msg *msg) break; } } + + /* Set output port, as defined by http://www.sflow.org/sflow_version_5.txt + (search for "Input/output port information"). */ if (!n_outputs) { /* This value indicates that the packet was dropped for an unknown * reason. */