From: Ben Pfaff <blp@cs.stanford.edu>
Date: Thu, 9 May 2013 04:07:39 +0000 (-0700)
Subject: psppire-cell-renderer-button: Do not update 'event->window'.
X-Git-Url: https://pintos-os.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3bbe2618aa0e89e189de004437ea20514fe500ad;p=pspp

psppire-cell-renderer-button: Do not update 'event->window'.

Commit 5b59146f8d0 (psppire-cell-renderer-button: Translate coords before
propagating event.) caused GDK and GTK+ warnings and criticals and a crash
if the scenario described in the bug report were repeated a number of
times.  This change appears to fix the problem.

Reported by John Darrington.
Bug #38922.
---

diff --git a/src/ui/gui/psppire-cell-renderer-button.c b/src/ui/gui/psppire-cell-renderer-button.c
index f312a01900..c1930518d7 100644
--- a/src/ui/gui/psppire-cell-renderer-button.c
+++ b/src/ui/gui/psppire-cell-renderer-button.c
@@ -349,7 +349,6 @@ psppire_cell_renderer_button_press_event (GtkButton      *button,
       gdk_window_coords_to_parent (event->window,
                                    event->x, event->y,
                                    &event->x, &event->y);
-      event->window = gdk_window_get_parent (event->window);
       g_signal_stop_emission_by_name (button, "button-press-event");
       return FALSE;
     }