From: Justin Pettit Date: Sat, 10 Mar 2012 19:04:42 +0000 (-0800) Subject: ovs-monitor-ipsec: Use all caps for global constants. X-Git-Url: https://pintos-os.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=38aad449247134b294df4872f52b831c3229a8b4;p=openvswitch ovs-monitor-ipsec: Use all caps for global constants. The convention in Python is to use all caps for global constants. Signed-off-by: Justin Pettit --- diff --git a/debian/ovs-monitor-ipsec b/debian/ovs-monitor-ipsec index 87a14911..a4a45754 100755 --- a/debian/ovs-monitor-ipsec +++ b/debian/ovs-monitor-ipsec @@ -42,7 +42,7 @@ import ovs.vlog vlog = ovs.vlog.Vlog("ovs-monitor-ipsec") root_prefix = '' # Prefix for absolute file names, for testing. -setkey = "/usr/sbin/setkey" +SETKEY = "/usr/sbin/setkey" exiting = False @@ -266,11 +266,11 @@ class IPsec: def call_setkey(self, cmds): try: - p = subprocess.Popen([root_prefix + setkey, "-c"], + p = subprocess.Popen([root_prefix + SETKEY, "-c"], stdin=subprocess.PIPE, stdout=subprocess.PIPE) except: - vlog.err("could not call %s%s" % (root_prefix, setkey)) + vlog.err("could not call %s%s" % (root_prefix, SETKEY)) sys.exit(1) # xxx It is safer to pass the string into the communicate()