From: Isaku Yamahata Date: Mon, 15 Oct 2012 21:57:27 +0000 (+0900) Subject: python/ovs/socket_util: don't use Exception, but ValueError X-Git-Url: https://pintos-os.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=378cc7f11274b21e6cc837129166b24a5281aa3c;p=openvswitch python/ovs/socket_util: don't use Exception, but ValueError 67656b9ff297f305b3bfcca2868e8e870e108283 used Exception, but it should be more specific error. Use ValueError instread of Exception. Suggested-by: Reid Price Signed-off-by: Isaku Yamahata Signed-off-by: Ben Pfaff --- diff --git a/python/ovs/socket_util.py b/python/ovs/socket_util.py index 845511e3..dd45fe4b 100644 --- a/python/ovs/socket_util.py +++ b/python/ovs/socket_util.py @@ -88,13 +88,13 @@ def inet_parse_active(target, default_port): address = target.split(":") host_name = address[0] if not host_name: - raise Exception("%s: bad peer name format" % target) + raise ValueError("%s: bad peer name format" % target) if len(address) >= 2: port = int(address[1]) elif default_port: port = default_port else: - raise Exception("%s: port number must be specified" % target) + raise ValueError("%s: port number must be specified" % target) return (host_name, port) @@ -187,6 +187,6 @@ def set_nonblocking(sock): def set_dscp(sock, dscp): if dscp > 63: - raise Exception("Invalid dscp %d" % dscp) + raise ValueError("Invalid dscp %d" % dscp) val = dscp << 2 sock.setsockopt(socket.IPPROTO_IP, socket.IP_TOS, val)