From: Ben Pfaff <blp@nicira.com>
Date: Thu, 28 Aug 2008 20:15:32 +0000 (-0700)
Subject: Fix test for fcntl return value.
X-Git-Url: https://pintos-os.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=305908583039cdd1c0229203a5b885ab97a17cce;p=openvswitch

Fix test for fcntl return value.

POSIX only says that -1 is an error; other return values have unspecified
meanings.
---

diff --git a/lib/daemon.c b/lib/daemon.c
index b5977172..58581b77 100644
--- a/lib/daemon.c
+++ b/lib/daemon.c
@@ -103,7 +103,7 @@ make_pidfile(void)
             lck.l_whence = SEEK_SET;
             lck.l_start = 0;
             lck.l_len = 0;
-            if (fcntl(fd, F_SETLK, &lck) >= 0) {
+            if (fcntl(fd, F_SETLK, &lck) != -1) {
                 char *text = xasprintf("%ld\n", pid);
                 if (write(fd, text, strlen(text)) == strlen(text)) {
                     fatal_signal_add_file_to_unlink(pidfile);