From: John Darrington <john@darrington.wattle.id.au>
Date: Mon, 7 Dec 2015 15:14:11 +0000 (+0100)
Subject: Remove destroy signal handler for dialogs.
X-Git-Url: https://pintos-os.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2aa28878fafb2cb6ea5466a2143b6fb77cf45fbf;hp=a232eb40325b126daabcdf28ca54da794bd6a29f;p=pspp

Remove destroy signal handler for dialogs.

Now (since the dialog persistance feature) dialog boxes survive their associated datasets,
it is no longer necessary or desireable for the destroy callback to remove the notification
callback.
---

diff --git a/src/ui/gui/psppire-dialog.c b/src/ui/gui/psppire-dialog.c
index aeecfee86e..43dd9af38d 100644
--- a/src/ui/gui/psppire-dialog.c
+++ b/src/ui/gui/psppire-dialog.c
@@ -296,13 +296,6 @@ psppire_dialog_notify_change (PsppireDialog *dialog)
 }
 
 
-static void
-remove_notify_handlers (PsppireDialog *dialog, GObject *sel)
-{
-  g_signal_handlers_disconnect_by_data (sel, dialog);
-}
-
-
 /* Descend the widget tree, connecting appropriate signals to the
    psppire_dialog_notify_change callback */
 static void
@@ -389,8 +382,6 @@ connect_notify_signal (GtkWidget *w, gpointer data)
 				    G_CALLBACK (psppire_dialog_notify_change),
 				    dialog);
 
-	  g_signal_connect (dialog, "destroy", G_CALLBACK (remove_notify_handlers),
-			    model);
 	}
       
       g_signal_connect_swapped (selection, "changed",