From: Ben Pfaff <blp@cs.stanford.edu>
Date: Sun, 27 Dec 2020 04:24:53 +0000 (-0800)
Subject: message-item: Fix reference counting in message_item_to_text_item().
X-Git-Url: https://pintos-os.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2720633be76a46488e05bb9a0d45f24a89375065;p=pspp

message-item: Fix reference counting in message_item_to_text_item().

This function should take ownership of the message_item passed in, but it
leaked a reference to it.
---

diff --git a/src/output/message-item.c b/src/output/message-item.c
index c60d166779..ddfcc3f42e 100644
--- a/src/output/message-item.c
+++ b/src/output/message-item.c
@@ -48,8 +48,10 @@ message_item_get_msg (const struct message_item *item)
 struct text_item *
 message_item_to_text_item (struct message_item *message_item)
 {
-  return text_item_create_nocopy (
+  struct text_item *text_item = text_item_create_nocopy (
     TEXT_ITEM_LOG, msg_to_string (message_item_get_msg (message_item)));
+  message_item_unref (message_item);
+  return text_item;
 }
 
 static void