From: Justin Pettit Date: Thu, 10 Nov 2011 07:39:16 +0000 (-0800) Subject: flow: Use FWW_ flags to wildcard IP DSCP and ECN. X-Git-Url: https://pintos-os.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2486e66ab570c261ba931c8333f1488f8eba5903;p=openvswitch flow: Use FWW_ flags to wildcard IP DSCP and ECN. It's no longer necessary to maintain a "nw_tos_mask" wildcard member, since we only care about completely wildcarding the DSCP and ECN portions of the IP TOS field. This commit makes that change. It also goes a bit further in internally using "tos" to refer to the entire TOS field (ie, DSCP and ECN). We must still refer to the DSCP portions as "nw_tos" externally through OpenFlow 1.0, since that's the convention it uses. --- diff --git a/lib/classifier.c b/lib/classifier.c index 9903ab70..ab56253c 100644 --- a/lib/classifier.c +++ b/lib/classifier.c @@ -315,7 +315,7 @@ cls_rule_set_nw_dst_masked(struct cls_rule *rule, ovs_be32 ip, ovs_be32 mask) void cls_rule_set_nw_dscp(struct cls_rule *rule, uint8_t nw_dscp) { - rule->wc.nw_tos_mask |= IP_DSCP_MASK; + rule->wc.wildcards &= ~FWW_NW_DSCP; rule->flow.nw_tos &= ~IP_DSCP_MASK; rule->flow.nw_tos |= nw_dscp & IP_DSCP_MASK; } @@ -323,7 +323,7 @@ cls_rule_set_nw_dscp(struct cls_rule *rule, uint8_t nw_dscp) void cls_rule_set_nw_ecn(struct cls_rule *rule, uint8_t nw_ecn) { - rule->wc.nw_tos_mask |= IP_ECN_MASK; + rule->wc.wildcards &= ~FWW_NW_ECN; rule->flow.nw_tos &= ~IP_ECN_MASK; rule->flow.nw_tos |= nw_ecn & IP_ECN_MASK; } @@ -477,7 +477,7 @@ cls_rule_format(const struct cls_rule *rule, struct ds *s) int i; - BUILD_ASSERT_DECL(FLOW_WC_SEQ == 6); + BUILD_ASSERT_DECL(FLOW_WC_SEQ == 7); if (rule->priority != OFP_DEFAULT_PRIORITY) { ds_put_format(s, "priority=%d,", rule->priority); @@ -622,10 +622,10 @@ cls_rule_format(const struct cls_rule *rule, struct ds *s) ETH_ADDR_ARGS(f->arp_tha)); } } - if (wc->nw_tos_mask & IP_DSCP_MASK) { + if (!(w & FWW_NW_DSCP)) { ds_put_format(s, "nw_tos=%"PRIu8",", f->nw_tos & IP_DSCP_MASK); } - if (wc->nw_tos_mask & IP_ECN_MASK) { + if (!(w & FWW_NW_ECN)) { ds_put_format(s, "nw_ecn=%"PRIu8",", f->nw_tos & IP_ECN_MASK); } if (!(w & FWW_NW_TTL)) { @@ -1177,7 +1177,7 @@ flow_equal_except(const struct flow *a, const struct flow *b, const flow_wildcards_t wc = wildcards->wildcards; int i; - BUILD_ASSERT_DECL(FLOW_WC_SEQ == 6); + BUILD_ASSERT_DECL(FLOW_WC_SEQ == 7); for (i = 0; i < FLOW_N_REGS; i++) { if ((a->regs[i] ^ b->regs[i]) & wildcards->reg_masks[i]) { @@ -1205,7 +1205,8 @@ flow_equal_except(const struct flow *a, const struct flow *b, || !((a->dl_dst[0] ^ b->dl_dst[0]) & 0x01)) && (wc & FWW_NW_PROTO || a->nw_proto == b->nw_proto) && (wc & FWW_NW_TTL || a->nw_ttl == b->nw_ttl) - && !((a->nw_tos ^ b->nw_tos) & wildcards->nw_tos_mask) + && (wc & FWW_NW_DSCP || !((a->nw_tos ^ b->nw_tos) & IP_DSCP_MASK)) + && (wc & FWW_NW_ECN || !((a->nw_tos ^ b->nw_tos) & IP_ECN_MASK)) && !((a->nw_frag ^ b->nw_frag) & wildcards->nw_frag_mask) && (wc & FWW_ARP_SHA || eth_addr_equals(a->arp_sha, b->arp_sha)) && (wc & FWW_ARP_THA || eth_addr_equals(a->arp_tha, b->arp_tha)) diff --git a/lib/flow.c b/lib/flow.c index 08c76d96..ec233bc9 100644 --- a/lib/flow.c +++ b/lib/flow.c @@ -439,7 +439,7 @@ flow_zero_wildcards(struct flow *flow, const struct flow_wildcards *wildcards) const flow_wildcards_t wc = wildcards->wildcards; int i; - BUILD_ASSERT_DECL(FLOW_WC_SEQ == 6); + BUILD_ASSERT_DECL(FLOW_WC_SEQ == 7); for (i = 0; i < FLOW_N_REGS; i++) { flow->regs[i] &= wildcards->reg_masks[i]; @@ -476,7 +476,12 @@ flow_zero_wildcards(struct flow *flow, const struct flow_wildcards *wildcards) if (wc & FWW_IPV6_LABEL) { flow->ipv6_label = htonl(0); } - flow->nw_tos &= wildcards->nw_tos_mask; + if (wc & FWW_NW_DSCP) { + flow->nw_tos &= ~IP_DSCP_MASK; + } + if (wc & FWW_NW_ECN) { + flow->nw_tos &= ~IP_ECN_MASK; + } if (wc & FWW_NW_TTL) { flow->nw_ttl = 0; } @@ -575,7 +580,7 @@ flow_print(FILE *stream, const struct flow *flow) void flow_wildcards_init_catchall(struct flow_wildcards *wc) { - BUILD_ASSERT_DECL(FLOW_WC_SEQ == 6); + BUILD_ASSERT_DECL(FLOW_WC_SEQ == 7); wc->wildcards = FWW_ALL; wc->tun_id_mask = htonll(0); @@ -585,7 +590,6 @@ flow_wildcards_init_catchall(struct flow_wildcards *wc) wc->ipv6_dst_mask = in6addr_any; memset(wc->reg_masks, 0, sizeof wc->reg_masks); wc->vlan_tci_mask = htons(0); - wc->nw_tos_mask = 0; wc->nw_frag_mask = 0; memset(wc->zeros, 0, sizeof wc->zeros); } @@ -595,7 +599,7 @@ flow_wildcards_init_catchall(struct flow_wildcards *wc) void flow_wildcards_init_exact(struct flow_wildcards *wc) { - BUILD_ASSERT_DECL(FLOW_WC_SEQ == 6); + BUILD_ASSERT_DECL(FLOW_WC_SEQ == 7); wc->wildcards = 0; wc->tun_id_mask = htonll(UINT64_MAX); @@ -605,7 +609,6 @@ flow_wildcards_init_exact(struct flow_wildcards *wc) wc->ipv6_dst_mask = in6addr_exact; memset(wc->reg_masks, 0xff, sizeof wc->reg_masks); wc->vlan_tci_mask = htons(UINT16_MAX); - wc->nw_tos_mask = UINT8_MAX; wc->nw_frag_mask = UINT8_MAX; memset(wc->zeros, 0, sizeof wc->zeros); } @@ -617,7 +620,7 @@ flow_wildcards_is_exact(const struct flow_wildcards *wc) { int i; - BUILD_ASSERT_DECL(FLOW_WC_SEQ == 6); + BUILD_ASSERT_DECL(FLOW_WC_SEQ == 7); if (wc->wildcards || wc->tun_id_mask != htonll(UINT64_MAX) @@ -626,7 +629,6 @@ flow_wildcards_is_exact(const struct flow_wildcards *wc) || wc->vlan_tci_mask != htons(UINT16_MAX) || !ipv6_mask_is_exact(&wc->ipv6_src_mask) || !ipv6_mask_is_exact(&wc->ipv6_dst_mask) - || wc->nw_tos_mask != UINT8_MAX || wc->nw_frag_mask != UINT8_MAX) { return false; } @@ -647,7 +649,7 @@ flow_wildcards_is_catchall(const struct flow_wildcards *wc) { int i; - BUILD_ASSERT_DECL(FLOW_WC_SEQ == 6); + BUILD_ASSERT_DECL(FLOW_WC_SEQ == 7); if (wc->wildcards != FWW_ALL || wc->tun_id_mask != htonll(0) @@ -656,7 +658,6 @@ flow_wildcards_is_catchall(const struct flow_wildcards *wc) || wc->vlan_tci_mask != htons(0) || !ipv6_mask_is_any(&wc->ipv6_src_mask) || !ipv6_mask_is_any(&wc->ipv6_dst_mask) - || wc->nw_tos_mask != 0 || wc->nw_frag_mask != 0) { return false; } diff --git a/lib/flow.h b/lib/flow.h index 75988ec0..3421d4fd 100644 --- a/lib/flow.h +++ b/lib/flow.h @@ -35,7 +35,7 @@ struct ofpbuf; /* This sequence number should be incremented whenever anything involving flows * or the wildcarding of flows changes. This will cause build assertion * failures in places which likely need to be updated. */ -#define FLOW_WC_SEQ 6 +#define FLOW_WC_SEQ 7 #define FLOW_N_REGS 5 BUILD_ASSERT_DECL(FLOW_N_REGS <= NXM_NX_MAX_REGS); @@ -87,7 +87,7 @@ BUILD_ASSERT_DECL(sizeof(((struct flow *)0)->nw_frag) == 1); BUILD_ASSERT_DECL(sizeof(struct flow) == FLOW_SIG_SIZE + FLOW_PAD_SIZE); /* Remember to update FLOW_WC_SEQ when changing 'struct flow'. */ -BUILD_ASSERT_DECL(FLOW_SIG_SIZE == 130 && FLOW_WC_SEQ == 6); +BUILD_ASSERT_DECL(FLOW_SIG_SIZE == 130 && FLOW_WC_SEQ == 7); void flow_extract(struct ofpbuf *, uint32_t priority, ovs_be64 tun_id, uint16_t in_port, struct flow *); @@ -145,10 +145,12 @@ typedef unsigned int OVS_BITWISE flow_wildcards_t; #define FWW_ND_TARGET ((OVS_FORCE flow_wildcards_t) (1 << 10)) #define FWW_IPV6_LABEL ((OVS_FORCE flow_wildcards_t) (1 << 11)) #define FWW_NW_TTL ((OVS_FORCE flow_wildcards_t) (1 << 12)) -#define FWW_ALL ((OVS_FORCE flow_wildcards_t) (((1 << 13)) - 1)) +#define FWW_NW_DSCP ((OVS_FORCE flow_wildcards_t) (1 << 13)) +#define FWW_NW_ECN ((OVS_FORCE flow_wildcards_t) (1 << 14)) +#define FWW_ALL ((OVS_FORCE flow_wildcards_t) (((1 << 15)) - 1)) /* Remember to update FLOW_WC_SEQ when adding or removing FWW_*. */ -BUILD_ASSERT_DECL(FWW_ALL == ((1 << 13) - 1) && FLOW_WC_SEQ == 6); +BUILD_ASSERT_DECL(FWW_ALL == ((1 << 15) - 1) && FLOW_WC_SEQ == 7); /* Information on wildcards for a flow, as a supplement to "struct flow". * @@ -163,13 +165,12 @@ struct flow_wildcards { struct in6_addr ipv6_src_mask; /* 1-bit in each signficant ipv6_src bit. */ struct in6_addr ipv6_dst_mask; /* 1-bit in each signficant ipv6_dst bit. */ ovs_be16 vlan_tci_mask; /* 1-bit in each significant vlan_tci bit. */ - uint8_t nw_tos_mask; /* 1-bit in each significant nw_tos bit. */ uint8_t nw_frag_mask; /* 1-bit in each significant nw_frag bit. */ - uint8_t zeros[4]; /* Padding field set to zero. */ + uint8_t zeros[5]; /* Padding field set to zero. */ }; /* Remember to update FLOW_WC_SEQ when updating struct flow_wildcards. */ -BUILD_ASSERT_DECL(sizeof(struct flow_wildcards) == 80 && FLOW_WC_SEQ == 6); +BUILD_ASSERT_DECL(sizeof(struct flow_wildcards) == 80 && FLOW_WC_SEQ == 7); void flow_wildcards_init_catchall(struct flow_wildcards *); void flow_wildcards_init_exact(struct flow_wildcards *); diff --git a/lib/meta-flow.c b/lib/meta-flow.c index 5569e15a..570d8a25 100644 --- a/lib/meta-flow.c +++ b/lib/meta-flow.c @@ -190,14 +190,14 @@ static const struct mf_field mf_fields[MFF_N_IDS] = { }, { MFF_IP_DSCP, "nw_tos", NULL, MF_FIELD_SIZES(u8), - MFM_NONE, 0, + MFM_NONE, FWW_NW_DSCP, MFS_DECIMAL, MFP_IP_ANY, NXM_OF_IP_TOS, }, { MFF_IP_ECN, "nw_ecn", NULL, 1, 2, - MFM_NONE, 0, + MFM_NONE, FWW_NW_ECN, MFS_DECIMAL, MFP_IP_ANY, NXM_NX_IP_ECN, @@ -376,6 +376,8 @@ mf_is_all_wild(const struct mf_field *mf, const struct flow_wildcards *wc) case MFF_ETH_SRC: case MFF_ETH_TYPE: case MFF_IP_PROTO: + case MFF_IP_DSCP: + case MFF_IP_ECN: case MFF_IP_TTL: case MFF_IPV6_LABEL: case MFF_ARP_OP: @@ -437,10 +439,6 @@ mf_is_all_wild(const struct mf_field *mf, const struct flow_wildcards *wc) case MFF_IPV6_DST: return ipv6_mask_is_any(&wc->ipv6_dst_mask); - case MFF_IP_DSCP: - return !(wc->nw_tos_mask & IP_DSCP_MASK); - case MFF_IP_ECN: - return !(wc->nw_tos_mask & IP_ECN_MASK); case MFF_IP_FRAG: return !(wc->nw_frag_mask & FLOW_NW_FRAG_MASK); @@ -470,6 +468,8 @@ mf_get_mask(const struct mf_field *mf, const struct flow_wildcards *wc, case MFF_ETH_SRC: case MFF_ETH_TYPE: case MFF_IP_PROTO: + case MFF_IP_DSCP: + case MFF_IP_ECN: case MFF_IP_TTL: case MFF_IPV6_LABEL: case MFF_ARP_OP: @@ -542,12 +542,6 @@ mf_get_mask(const struct mf_field *mf, const struct flow_wildcards *wc, mask->ipv6 = wc->ipv6_dst_mask; break; - case MFF_IP_DSCP: - mask->u8 = wc->nw_tos_mask & IP_DSCP_MASK; - break; - case MFF_IP_ECN: - mask->u8 = wc->nw_tos_mask & IP_ECN_MASK; - break; case MFF_IP_FRAG: mask->u8 = wc->nw_frag_mask & FLOW_NW_FRAG_MASK; break; @@ -1158,12 +1152,12 @@ mf_set_wild(const struct mf_field *mf, struct cls_rule *rule) break; case MFF_IP_DSCP: - rule->wc.nw_tos_mask |= IP_DSCP_MASK; + rule->wc.wildcards |= FWW_NW_DSCP; rule->flow.nw_tos &= ~IP_DSCP_MASK; break; case MFF_IP_ECN: - rule->wc.nw_tos_mask |= IP_ECN_MASK; + rule->wc.wildcards |= FWW_NW_ECN; rule->flow.nw_tos &= ~IP_ECN_MASK; break; diff --git a/lib/nx-match.c b/lib/nx-match.c index b1551795..8c4bf509 100644 --- a/lib/nx-match.c +++ b/lib/nx-match.c @@ -461,7 +461,7 @@ nx_put_match(struct ofpbuf *b, const struct cls_rule *cr) int match_len; int i; - BUILD_ASSERT_DECL(FLOW_WC_SEQ == 6); + BUILD_ASSERT_DECL(FLOW_WC_SEQ == 7); /* Metadata. */ if (!(wc & FWW_IN_PORT)) { @@ -489,11 +489,11 @@ nx_put_match(struct ofpbuf *b, const struct cls_rule *cr) nxm_put_32m(b, NXM_OF_IP_DST, flow->nw_dst, cr->wc.nw_dst_mask); nxm_put_frag(b, cr); - if (cr->wc.nw_tos_mask & IP_DSCP_MASK) { + if (!(wc & FWW_NW_DSCP)) { nxm_put_8(b, NXM_OF_IP_TOS, flow->nw_tos & IP_DSCP_MASK); } - if (cr->wc.nw_tos_mask & IP_ECN_MASK) { + if (!(wc & FWW_NW_ECN)) { nxm_put_8(b, NXM_NX_IP_ECN, flow->nw_tos & IP_ECN_MASK); } @@ -547,11 +547,11 @@ nx_put_match(struct ofpbuf *b, const struct cls_rule *cr) nxm_put_32(b, NXM_NX_IPV6_LABEL, flow->ipv6_label); } - if (cr->wc.nw_tos_mask & IP_DSCP_MASK) { + if (!(wc & FWW_NW_DSCP)) { nxm_put_8(b, NXM_OF_IP_TOS, flow->nw_tos & IP_DSCP_MASK); } - if (cr->wc.nw_tos_mask & IP_ECN_MASK) { + if (!(wc & FWW_NW_ECN)) { nxm_put_8(b, NXM_NX_IP_ECN, flow->nw_tos & IP_ECN_MASK); } diff --git a/lib/ofp-util.c b/lib/ofp-util.c index b6a35b04..3c004dcd 100644 --- a/lib/ofp-util.c +++ b/lib/ofp-util.c @@ -101,18 +101,20 @@ static const flow_wildcards_t WC_INVARIANTS = 0 void ofputil_wildcard_from_openflow(uint32_t ofpfw, struct flow_wildcards *wc) { - BUILD_ASSERT_DECL(FLOW_WC_SEQ == 6); + BUILD_ASSERT_DECL(FLOW_WC_SEQ == 7); /* Initialize most of rule->wc. */ flow_wildcards_init_catchall(wc); wc->wildcards = (OVS_FORCE flow_wildcards_t) ofpfw & WC_INVARIANTS; /* Wildcard fields that aren't defined by ofp_match or tun_id. */ - wc->wildcards |= (FWW_ARP_SHA | FWW_ARP_THA | FWW_NW_TTL + wc->wildcards |= (FWW_ARP_SHA | FWW_ARP_THA | FWW_NW_ECN | FWW_NW_TTL | FWW_ND_TARGET | FWW_IPV6_LABEL); - if (!(ofpfw & OFPFW_NW_TOS)) { - wc->nw_tos_mask |= IP_DSCP_MASK; + if (ofpfw & OFPFW_NW_TOS) { + /* OpenFlow 1.0 defines a TOS wildcard, but it's much later in + * the enum than we can use. */ + wc->wildcards |= FWW_NW_DSCP; } wc->nw_src_mask = ofputil_wcbits_to_netmask(ofpfw >> OFPFW_NW_SRC_SHIFT); @@ -194,7 +196,7 @@ ofputil_cls_rule_to_match(const struct cls_rule *rule, struct ofp_match *match) ofpfw = (OVS_FORCE uint32_t) (wc->wildcards & WC_INVARIANTS); ofpfw |= ofputil_netmask_to_wcbits(wc->nw_src_mask) << OFPFW_NW_SRC_SHIFT; ofpfw |= ofputil_netmask_to_wcbits(wc->nw_dst_mask) << OFPFW_NW_DST_SHIFT; - if (!(wc->nw_tos_mask & IP_DSCP_MASK)) { + if (wc->wildcards & FWW_NW_DSCP) { ofpfw |= OFPFW_NW_TOS; } @@ -859,7 +861,7 @@ ofputil_min_flow_format(const struct cls_rule *rule) { const struct flow_wildcards *wc = &rule->wc; - BUILD_ASSERT_DECL(FLOW_WC_SEQ == 6); + BUILD_ASSERT_DECL(FLOW_WC_SEQ == 7); /* Only NXM supports separately wildcards the Ethernet multicast bit. */ if (!(wc->wildcards & FWW_DL_DST) != !(wc->wildcards & FWW_ETH_MCAST)) { @@ -898,7 +900,7 @@ ofputil_min_flow_format(const struct cls_rule *rule) } /* Only NXM supports matching IP ECN bits. */ - if (wc->nw_tos_mask & IP_ECN_MASK) { + if (!(wc->wildcards & FWW_NW_ECN)) { return NXFF_NXM; } @@ -2573,8 +2575,8 @@ ofputil_normalize_rule(struct cls_rule *rule, enum nx_flow_format flow_format) wc.wildcards |= FWW_NW_PROTO; } if (!(may_match & MAY_IPVx)) { - wc.nw_tos_mask = 0; - wc.nw_frag_mask = 0; + wc.wildcards |= FWW_NW_DSCP; + wc.wildcards |= FWW_NW_ECN; wc.wildcards |= FWW_NW_TTL; } if (!(may_match & MAY_ARP_SHA)) { diff --git a/tests/test-classifier.c b/tests/test-classifier.c index d167574d..8dfe016c 100644 --- a/tests/test-classifier.c +++ b/tests/test-classifier.c @@ -55,7 +55,7 @@ CLS_FIELD(FWW_DL_SRC, dl_src, DL_SRC) \ CLS_FIELD(FWW_DL_DST | FWW_ETH_MCAST, dl_dst, DL_DST) \ CLS_FIELD(FWW_NW_PROTO, nw_proto, NW_PROTO) \ - CLS_FIELD(0, nw_tos, NW_TOS) + CLS_FIELD(FWW_NW_DSCP, nw_tos, NW_DSCP) /* Field indexes. * @@ -203,9 +203,8 @@ match(const struct cls_rule *wild, const struct flow *fixed) & wild->wc.vlan_tci_mask); } else if (f_idx == CLS_F_IDX_TUN_ID) { eq = !((fixed->tun_id ^ wild->flow.tun_id) & wild->wc.tun_id_mask); - } else if (f_idx == CLS_F_IDX_NW_TOS) { - eq = !((fixed->nw_tos ^ wild->flow.nw_tos) - & wild->wc.nw_tos_mask); + } else if (f_idx == CLS_F_IDX_NW_DSCP) { + eq = !((fixed->nw_tos ^ wild->flow.nw_tos) & IP_DSCP_MASK); } else { NOT_REACHED(); } @@ -266,7 +265,7 @@ static uint8_t dl_src_values[][6] = { { 0x00, 0x02, 0xe3, 0x0f, 0x80, 0xa4 }, static uint8_t dl_dst_values[][6] = { { 0x4a, 0x27, 0x71, 0xae, 0x64, 0xc1 }, { 0xff, 0xff, 0xff, 0xff, 0xff, 0xff } }; static uint8_t nw_proto_values[] = { IPPROTO_TCP, IPPROTO_ICMP }; -static uint8_t nw_tos_values[] = { 48, 0 }; +static uint8_t nw_dscp_values[] = { 48, 0 }; static void *values[CLS_N_FIELDS][2]; @@ -300,8 +299,8 @@ init_values(void) values[CLS_F_IDX_NW_PROTO][0] = &nw_proto_values[0]; values[CLS_F_IDX_NW_PROTO][1] = &nw_proto_values[1]; - values[CLS_F_IDX_NW_TOS][0] = &nw_tos_values[0]; - values[CLS_F_IDX_NW_TOS][1] = &nw_tos_values[1]; + values[CLS_F_IDX_NW_DSCP][0] = &nw_dscp_values[0]; + values[CLS_F_IDX_NW_DSCP][1] = &nw_dscp_values[1]; values[CLS_F_IDX_TP_SRC][0] = &tp_src_values[0]; values[CLS_F_IDX_TP_SRC][1] = &tp_src_values[1]; @@ -321,7 +320,7 @@ init_values(void) #define N_DL_SRC_VALUES ARRAY_SIZE(dl_src_values) #define N_DL_DST_VALUES ARRAY_SIZE(dl_dst_values) #define N_NW_PROTO_VALUES ARRAY_SIZE(nw_proto_values) -#define N_NW_TOS_VALUES ARRAY_SIZE(nw_tos_values) +#define N_NW_DSCP_VALUES ARRAY_SIZE(nw_dscp_values) #define N_FLOW_VALUES (N_NW_SRC_VALUES * \ N_NW_DST_VALUES * \ @@ -334,7 +333,7 @@ init_values(void) N_DL_SRC_VALUES * \ N_DL_DST_VALUES * \ N_NW_PROTO_VALUES * \ - N_NW_TOS_VALUES) + N_NW_DSCP_VALUES) static unsigned int get_value(unsigned int *x, unsigned n_values) @@ -370,7 +369,7 @@ compare_classifiers(struct classifier *cls, struct tcls *tcls) memcpy(flow.dl_dst, dl_dst_values[get_value(&x, N_DL_DST_VALUES)], ETH_ADDR_LEN); flow.nw_proto = nw_proto_values[get_value(&x, N_NW_PROTO_VALUES)]; - flow.nw_tos = nw_tos_values[get_value(&x, N_NW_TOS_VALUES)]; + flow.nw_tos = nw_dscp_values[get_value(&x, N_NW_DSCP_VALUES)]; cr0 = classifier_lookup(cls, &flow); cr1 = tcls_lookup(tcls, &flow); @@ -468,8 +467,6 @@ make_rule(int wc_fields, unsigned int priority, int value_pat) rule->cls_rule.wc.vlan_tci_mask = htons(UINT16_MAX); } else if (f_idx == CLS_F_IDX_TUN_ID) { rule->cls_rule.wc.tun_id_mask = htonll(UINT64_MAX); - } else if (f_idx == CLS_F_IDX_NW_TOS) { - rule->cls_rule.wc.nw_tos_mask = UINT8_MAX; } else { NOT_REACHED(); }