From: Bruno Haible <bruno@clisp.org>
Date: Sun, 11 Feb 2007 17:45:10 +0000 (+0000)
Subject: Fix bug.
X-Git-Url: https://pintos-os.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=21cc2c8123603268d830a61fdb08d4b59881461f;p=pspp

Fix bug.
Add tests.
---

diff --git a/ChangeLog b/ChangeLog
index c521d8617c..633a054441 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,11 @@
+2007-02-11  Bruno Haible  <bruno@clisp.org>
+
+	* lib/mbsrchr.c (mbsrchr): Fix bug.
+
+	* modules/mbsrchr-tests: New file.
+	* tests/test-mbsrchr.sh: New file.
+	* tests/test-mbsrchr.c: New file.
+
 2007-02-11  Bruno Haible  <bruno@clisp.org>
 
 	* lib/mbschr.c (mbschr): Fix bug.
diff --git a/lib/mbsrchr.c b/lib/mbsrchr.c
index f3b2808451..9cc9ca8f0f 100644
--- a/lib/mbsrchr.c
+++ b/lib/mbsrchr.c
@@ -40,13 +40,11 @@ mbsrchr (const char *string, int c)
       const char *result = NULL;
       mbui_iterator_t iter;
 
-      for (mbui_init (iter, string);; mbui_advance (iter))
+      for (mbui_init (iter, string); mbui_avail (iter); mbui_advance (iter))
 	{
 	  if (mb_len (mbui_cur (iter)) == 1
 	      && (unsigned char) * mbui_cur_ptr (iter) == (unsigned char) c)
 	    result = mbui_cur_ptr (iter);
-	  if (!mbui_avail (iter))
-	    break;
 	}
       return (char *) result;
     }