From: John Darrington <john@darrington.wattle.id.au>
Date: Sat, 29 Aug 2015 12:42:29 +0000 (+0200)
Subject: Don't bother freeing import dialog memory. Thus avoid crashes.
X-Git-Url: https://pintos-os.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=1a528fdab462b59506d56b3d20c5c96455f5e561;p=pspp

Don't bother freeing import dialog memory. Thus avoid crashes.

A number of users have complained that the import dialog assistant
crashes on exit.  This seems to be because some callback is accessing
the data after it has been freed.

This change "fixes" that by simply not ever freeing the data.  This
will cause a memory leak.  However during my investigations, I have
found that this dialog leaks so much anyway that these few bytes are
hardly significant.

A proper fix will hopefully be forthcoming.

Affects bug #45805
---

diff --git a/src/ui/gui/text-data-import-dialog.c b/src/ui/gui/text-data-import-dialog.c
index 1527028c28..34127492fa 100644
--- a/src/ui/gui/text-data-import-dialog.c
+++ b/src/ui/gui/text-data-import-dialog.c
@@ -138,10 +138,6 @@ text_data_import_assistant (PsppireDataWindow *dw)
       destroy_formats_page (ia);
       destroy_separators_page (ia);
     }
-
-  destroy_assistant (ia);
-  destroy_file (ia);
-  free (ia);
 }
 
 /* Emits PSPP syntax to S that applies the dictionary attributes