From: Ben Pfaff Date: Mon, 5 Oct 2009 03:37:10 +0000 (-0700) Subject: hmap-test: Skip test instead of reporting success on GCC 4.3. X-Git-Tag: sav-api~248^2~37 X-Git-Url: https://pintos-os.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=11ff86cb02ecfe1895873e524a216266ccd3c2eb;p=pspp hmap-test: Skip test instead of reporting success on GCC 4.3. Commit 1dfc6b1 "hmap-test: Disable tests that GCC 4.3 miscompiles." disabled some of the hmap-tests, the ones that GCC 4.3 miscompiles. However, it still reported "success" if the remaining tests succeeded. John Darrington suggested that reporting that the test was skipped was more accurate, so this commit does so. --- diff --git a/tests/libpspp/hmap-test.c b/tests/libpspp/hmap-test.c index 4e072c94f2..4ca7f92fd7 100644 --- a/tests/libpspp/hmap-test.c +++ b/tests/libpspp/hmap-test.c @@ -1000,5 +1000,12 @@ main (void) putchar ('\n'); +#if __GNUC__ == 4 && __GNUC_MINOR__ == 3 + /* We skipped some of the tests, so return a value that + Automake will interpret as "skipped", instead of one that + means success. */ + return 77; +#else return 0; +#endif }