From: Ben Pfaff <blp@cs.stanford.edu>
Date: Sun, 12 Dec 2010 05:09:17 +0000 (-0800)
Subject: friedman: Fix GCC warning about uninitialized fr.w.
X-Git-Tag: v0.7.7~117
X-Git-Url: https://pintos-os.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=036ae30df61b1c998e1aa027863ac2349a67066b;p=pspp-builds.git

friedman: Fix GCC warning about uninitialized fr.w.

On my machine GCC 4.4 complains:
friedman.c: In function ‘friedman_execute’:
friedman.c:106: warning: ‘fr.w’ may be used uninitialized in this function

This appears to be because GCC can't see that the assignment to fr.w and
its later use (in show_sig_box()) both have the same condition.  At any
rate, this commit suppresses the warning by always initializing fr.w.
---

diff --git a/src/language/stats/friedman.c b/src/language/stats/friedman.c
index 9711167b..9950543f 100644
--- a/src/language/stats/friedman.c
+++ b/src/language/stats/friedman.c
@@ -202,6 +202,8 @@ friedman_execute (const struct dataset *ds,
       fr.w /= pow2 (fr.cc) * (pow3 (ost->n_vars) - ost->n_vars)
 	- fr.cc * sigma_t;
     }
+  else
+    fr.w = SYSMIS;
 
   show_ranks_box (ost, &fr);
   show_sig_box (ost, &fr);