From: Ben Pfaff <blp@cs.stanford.edu>
Date: Sat, 1 Jan 2011 23:54:54 +0000 (-0800)
Subject: variable-parser: Drop VAR_NAME_LEN restriction from var_set_lookup_var_idx().
X-Git-Tag: v0.7.7~65
X-Git-Url: https://pintos-os.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=01b8f463e64469622cfe56f123e23a45d36d5d52;p=pspp-builds.git

variable-parser: Drop VAR_NAME_LEN restriction from var_set_lookup_var_idx().

This restriction is purely artificial, as part of an assertion.  Since
longer variable names are going to have to be supported, remove it.

Most uses of VAR_NAME_LEN within PSPP are wrong due to encoding issues:
the limit applies to variable names in the encoding used by the data
set, but most uses of VAR_NAME_LEN actually limit the length of a name
in UTF-8.  The UTF-8 representation of a name can be longer or shorter
than its representation in the data set encoding, so it seems best to
eliminate references to VAR_NAME_LEN entirely.
---

diff --git a/src/language/lexer/variable-parser.c b/src/language/lexer/variable-parser.c
index 0cefb5db..84cf9725 100644
--- a/src/language/lexer/variable-parser.c
+++ b/src/language/lexer/variable-parser.c
@@ -709,7 +709,6 @@ var_set_lookup_var_idx (const struct var_set *vs, const char *name,
 {
   assert (vs != NULL);
   assert (name != NULL);
-  assert (strlen (name) <= VAR_NAME_LEN);
 
   return vs->lookup_var_idx (vs, name, idx);
 }