From: Ben Pfaff <blp@gnu.org>
Date: Thu, 1 Apr 2004 06:38:35 +0000 (+0000)
Subject: Use moments data structure on FREQUENCIES.
X-Git-Tag: v0.4.0~292
X-Git-Url: https://pintos-os.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=00fc43143334ef109424b6e4d9d0a0917eac5563;p=pspp-builds.git

Use moments data structure on FREQUENCIES.
---

diff --git a/src/ChangeLog b/src/ChangeLog
index 5514d1f5..debb7021 100644
--- a/src/ChangeLog
+++ b/src/ChangeLog
@@ -1,3 +1,8 @@
+Wed Mar 31 22:36:22 2004  Ben Pfaff  <blp@gnu.org>
+
+	* frequencies.q: (calc_stats) Use moments data structure and
+	calc_seskew(), calc_sekurt() functions.
+
 Tue Mar 30 22:04:19 2004  Ben Pfaff  <blp@gnu.org>
 
 	* vfm.c: Had to get last call to multipass_split_output() inside
diff --git a/src/frequencies.q b/src/frequencies.q
index c65567e8..4ae03793 100644
--- a/src/frequencies.q
+++ b/src/frequencies.q
@@ -33,6 +33,7 @@
 #include "pool.h"
 #include "command.h"
 #include "lexer.h"
+#include "moments.h"
 #include "error.h"
 #include "algorithm.h"
 #include "magic.h"
@@ -1168,20 +1169,15 @@ static void
 calc_stats (struct variable * v, double d[frq_n_stats])
 {
   double W = v->p.frq.tab.valid_cases;
-  double X_bar, X_mode, M2, M3, M4;
+  struct moments *m;
   struct freq *f;
   int most_often;
+  double X_mode;
 
   double cum_total;
   int i = 0;
   double previous_value;
 
-  /* Calculate the mean. */
-  X_bar = 0.0;
-  for (f = v->p.frq.tab.valid; f < v->p.frq.tab.missing; f++)
-    X_bar += f->v.f * f->c;
-  X_bar /= W;
-
   /* Calculate percentiles. */
   cum_total = 0;
   previous_value = SYSMIS;
@@ -1216,56 +1212,27 @@ calc_stats (struct variable * v, double d[frq_n_stats])
         }
     }
 
-  /* Calculate moments about the mean. */
-  M2 = M3 = M4 = 0.0;
+  /* Calculate moments. */
+  m = moments_create (MOMENT_KURTOSIS);
   for (f = v->p.frq.tab.valid; f < v->p.frq.tab.missing; f++)
-    {
-      double dev = f->v.f - X_bar;
-      double tmp;
-      tmp = dev * dev;
-      M2 += f->c * tmp;
-      tmp *= dev;
-      M3 += f->c * tmp;
-      tmp *= dev;
-      M4 += f->c * tmp;
-    }
-
+    moments_pass_one (m, f->v.f, f->c);
+  for (f = v->p.frq.tab.valid; f < v->p.frq.tab.missing; f++)
+    moments_pass_two (m, f->v.f, f->c);
+  moments_calculate (m, NULL, &d[frq_mean], &d[frq_variance],
+                     &d[frq_skew], &d[frq_kurt]);
+  moments_destroy (m);
+                     
   /* Formulas below are taken from _SPSS Statistical Algorithms_. */
   d[frq_min] = v->p.frq.tab.valid[0].v.f;
   d[frq_max] = v->p.frq.tab.valid[v->p.frq.tab.n_valid - 1].v.f;
   d[frq_mode] = X_mode;
   d[frq_range] = d[frq_max] - d[frq_min];
   d[frq_median] = SYSMIS;
-  d[frq_mean] = X_bar;
-  d[frq_sum] = X_bar * W;
-  d[frq_variance] = M2 / (W - 1);
+  d[frq_sum] = d[frq_mean] * W;
   d[frq_stddev] = sqrt (d[frq_variance]);
   d[frq_semean] = d[frq_stddev] / sqrt (W);
-  if (W >= 3.0 && d[frq_variance] > 0)
-    {
-      double S = d[frq_stddev];
-      d[frq_skew] = (W * M3 / ((W - 1.0) * (W - 2.0) * S * S * S));
-      d[frq_seskew] = sqrt (6.0 * W * (W - 1.0)
-			    / ((W - 2.0) * (W + 1.0) * (W + 3.0)));
-    }
-  else
-    {
-      d[frq_skew] = d[frq_seskew] = SYSMIS;
-    }
-  if (W >= 4.0 && d[frq_variance] > 0)
-    {
-      double S2 = d[frq_variance];
-      double SE_g1 = d[frq_seskew];
-
-      d[frq_kurt] = ((W * (W + 1.0) * M4 - 3.0 * M2 * M2 * (W - 1.0))
-		     / ((W - 1.0) * (W - 2.0) * (W - 3.0) * S2 * S2));
-      d[frq_sekurt] = sqrt ((4.0 * (W * W - 1.0) * SE_g1 * SE_g1)
-			    / ((W - 3.0) * (W + 5.0)));
-    }
-  else
-    {
-      d[frq_kurt] = d[frq_sekurt] = SYSMIS;
-    }
+  d[frq_seskew] = calc_seskew (W);
+  d[frq_sekurt] = calc_sekurt (W);
 }
 
 /* Displays a table of all the statistics requested for variable V. */