From: Ben Pfaff <blp@cs.stanford.edu>
Date: Thu, 13 Jan 2022 05:50:54 +0000 (-0800)
Subject: psppire-dialog-action-crosstabs: Do not add PIVOT or NOPIVOT to command.
X-Git-Url: https://pintos-os.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;ds=sidebyside;h=797d4cf7f997bea8743e73ab0a54c00c715a1f94;p=pspp

psppire-dialog-action-crosstabs: Do not add PIVOT or NOPIVOT to command.

The CROSSTABS command does not support /FORMAT=PIVOT or /FORMAT=NOPIVOT.
I can't find any evidence that it ever did.  Perhaps q2c ignored keywords
it didn't recognize?  SPSS does not document support for any such format
keywords, so it's better to remove them from the emitted syntax than to
add support to CROSSTABS.

Thanks to Alexandra Younger for reporting the issue.
---

diff --git a/src/ui/gui/psppire-dialog-action-crosstabs.c b/src/ui/gui/psppire-dialog-action-crosstabs.c
index 6ea08a88cb..3c2bd59579 100644
--- a/src/ui/gui/psppire-dialog-action-crosstabs.c
+++ b/src/ui/gui/psppire-dialog-action-crosstabs.c
@@ -296,13 +296,6 @@ generate_syntax (const PsppireDialogAction *a)
     g_string_append (string, "TABLES");
   else
     g_string_append (string, "NOTABLES");
-  g_string_append (string, " ");
-
-  if (cd->format_options_pivot)
-    g_string_append (string, "PIVOT");
-  else
-    g_string_append (string, "NOPIVOT");
-
 
   selected = 0;
   for (i = 0, ok = gtk_tree_model_get_iter_first (cd->stat, &iter); ok;