sha1.c, md5.c: Hoist a redundant expression.

* lib/sha1.c (sha1_process_bytes): AND-off the low bits in
"ctx->buflen" only once, before calling *_process_block.
* lib/md5.c (md5_process_bytes): Likewise.

diff --git a/ChangeLog b/ChangeLog
index a58f6378569179ea2f852bdde5f81c8318b5b8ce..97d711f4c3611b6184eca9292b86cc0869895a3e 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2008-03-15  Jim Meyering  <meyering@redhat.com>
+
+       sha1.c, md5.c: Hoist a redundant expression.
+       * lib/sha1.c (sha1_process_bytes): AND-off the low bits in
+       "ctx->buflen" only once, before calling *_process_block.
+       * lib/md5.c (md5_process_bytes): Likewise.
+
 2008-03-14  Eric Blake  <ebb9@byu.net>
 
        Bump copyright year in files generated by gnulib-tool.

diff --git a/lib/md5.c b/lib/md5.c
index 2213dc1206581b936641647c1826cb8d6328bc59..ce02a26211e6ca607de5da8433834cdfd791d8e5 100644 (file)
--- a/lib/md5.c
+++ b/lib/md5.c
@@ -230,9 +230,9 @@ md5_process_bytes (const void *buffer, size_t len, struct md5_ctx *ctx)
 
       if (ctx->buflen > 64)
        {
-         md5_process_block (ctx->buffer, ctx->buflen & ~63, ctx);
-
          ctx->buflen &= 63;
+         md5_process_block (ctx->buffer, ctx->buflen, ctx);
+
          /* The regions in the following copy operation cannot overlap.  */
          memcpy (ctx->buffer,
                  &((char *) ctx->buffer)[(left_over + add) & ~63],

diff --git a/lib/sha1.c b/lib/sha1.c
index 9c6c7ae3933d7b45a945a2404414b01bd2e4e95d..67d5c964c6040471a3e5d0255f880ecf16075738 100644 (file)
--- a/lib/sha1.c
+++ b/lib/sha1.c
@@ -217,9 +217,9 @@ sha1_process_bytes (const void *buffer, size_t len, struct sha1_ctx *ctx)
 
       if (ctx->buflen > 64)
        {
-         sha1_process_block (ctx->buffer, ctx->buflen & ~63, ctx);
-
          ctx->buflen &= 63;
+         sha1_process_block (ctx->buffer, ctx->buflen, ctx);
+
          /* The regions in the following copy operation cannot overlap.  */
          memcpy (ctx->buffer,
                  &((char *) ctx->buffer)[(left_over + add) & ~63],