daemon: report error if daemon child process fails to start properly

Found by Chris Eagle via Fortify.

diff --git a/lib/daemon.c b/lib/daemon.c
index 3f417d420ddae5e257658157080754ff74774ff4..4d7b044b0f2e913c4a1eb20fa2020ac7d2043011 100644 (file)
--- a/lib/daemon.c
+++ b/lib/daemon.c
@@ -214,7 +214,9 @@ daemonize(void)
             /* Parent process: wait for child to create pidfile, then exit. */
             close(fds[1]);
             fatal_signal_fork();
-            read(fds[0], &c, 1);
+            if (read(fds[0], &c, 1) != 1) {
+                ofp_fatal(errno, "daemon child failed to signal startup");
+            }
             exit(0);
 
         case 0: