ofp-util: Improve return type of ofputil_decode_packet_in().

"enum ofperr" is clearer than "int".

Reviewed-by: Simon Horman <horms@verge.net.au>
Signed-off-by: Ben Pfaff <blp@nicira.com>

diff --git a/lib/ofp-util.c b/lib/ofp-util.c
index 07f885d2b68c15653e4bd776b36965aa680f7b87..6d820b2f40e3654986c716d2e27721b6ab21a5c5 100644 (file)
--- a/lib/ofp-util.c
+++ b/lib/ofp-util.c
@@ -2318,7 +2318,7 @@ ofputil_encode_flow_removed(const struct ofputil_flow_removed *fr,
     return msg;
 }
 
-int
+enum ofperr
 ofputil_decode_packet_in(struct ofputil_packet_in *pin,
                          const struct ofp_header *oh)
 {

diff --git a/lib/ofp-util.h b/lib/ofp-util.h
index 6b3128a5a100b02b085dd6df0b1bc61b8dad0766..aaab83cbdbc091f0b65af45a4ad4d250863b71cc 100644 (file)
--- a/lib/ofp-util.h
+++ b/lib/ofp-util.h
@@ -334,8 +334,8 @@ struct ofputil_packet_in {
     struct flow_metadata fmd;   /* Metadata at creation time. */
 };
 
-int ofputil_decode_packet_in(struct ofputil_packet_in *,
-                             const struct ofp_header *);
+enum ofperr ofputil_decode_packet_in(struct ofputil_packet_in *,
+                                     const struct ofp_header *);
 struct ofpbuf *ofputil_encode_packet_in(const struct ofputil_packet_in *,
                                         enum nx_packet_in_format);