packets: Make flow_extract() output a pointer to L7 data also.

Useful for the DHCP client, which wants to pick apart UDP packets
and extract the DHCP payload.

diff --git a/include/buffer.h b/include/buffer.h
index 2fe05c33a0e03900aba1629f43a33a0c0f87dbda..e1718007b538f1f67a2c22fabb6ac7d26dfd698a 100644 (file)
--- a/include/buffer.h
+++ b/include/buffer.h
@@ -48,6 +48,7 @@ struct buffer {
     void *l2;                   /* Link-level header. */
     void *l3;                   /* Network-level header. */
     void *l4;                   /* Transport-level header. */
+    void *l7;                   /* Application data. */
 
     struct buffer *next;        /* Next in a list of buffers. */
 };

diff --git a/lib/buffer.c b/lib/buffer.c
index 637828d44a65c59270777c40dded7b906d5835a0..1abe240647f8721ed93367c11de0bc14a6447333 100644 (file)
--- a/lib/buffer.c
+++ b/lib/buffer.c
@@ -50,7 +50,7 @@ buffer_use(struct buffer *b, void *base, size_t allocated)
     b->base = b->data = base;
     b->allocated = allocated;
     b->size = 0;
-    b->l2 = b->l3 = b->l4 = NULL;
+    b->l2 = b->l3 = b->l4 = b->l7 = NULL;
     b->next = NULL;
 }
 
@@ -148,6 +148,9 @@ buffer_prealloc_tailroom(struct buffer *b, size_t size)
         if (b->l4) {
             b->l4 += base_delta;
         }
+        if (b->l7) {
+            b->l7 += base_delta;
+        }
     }
 }
 

diff --git a/lib/flow.c b/lib/flow.c
index 53da6e9c3abaf8227331771d9166e7573e3859b5..449a286f78dea7144415d56a944c8902c671bd01 100644 (file)
--- a/lib/flow.c
+++ b/lib/flow.c
@@ -43,6 +43,44 @@
 #include "vlog.h"
 #define THIS_MODULE VLM_flow
 
+struct ip_header *
+pull_ip(struct buffer *packet)
+{
+    if (packet->size >= IP_HEADER_LEN) {
+        struct ip_header *ip = packet->data;
+        int ip_len = IP_IHL(ip->ip_ihl_ver) * 4;
+        if (ip_len >= IP_HEADER_LEN && packet->size >= ip_len) {
+            return buffer_pull(packet, ip_len);
+        }
+    }
+    return NULL;
+}
+
+struct tcp_header *
+pull_tcp(struct buffer *packet) 
+{
+    if (packet->size >= TCP_HEADER_LEN) {
+        struct tcp_header *tcp = packet->data;
+        int tcp_len = TCP_OFFSET(tcp->tcp_ctl) * 4;
+        if (tcp_len >= TCP_HEADER_LEN && packet->size >= tcp_len) {
+            return buffer_pull(packet, tcp_len);
+        }
+    }
+    return NULL;
+}
+
+struct udp_header *
+pull_udp(struct buffer *packet) 
+{
+    return buffer_try_pull(packet, UDP_HEADER_LEN);
+}
+
+struct eth_header *
+pull_eth(struct buffer *packet) 
+{
+    return buffer_try_pull(packet, ETH_HEADER_LEN);
+}
+
 void
 flow_extract(struct buffer *packet, uint16_t in_port, struct flow *flow)
 {
@@ -64,10 +102,10 @@ flow_extract(struct buffer *packet, uint16_t in_port, struct flow *flow)
     packet->l2 = b.data;
     packet->l3 = NULL;
     packet->l4 = NULL;
+    packet->l7 = NULL;
 
-    eth = buffer_at(&b, 0, sizeof *eth);
+    eth = pull_eth(&b);
     if (eth) {
-        buffer_pull(&b, ETH_HEADER_LEN);
         if (ntohs(eth->eth_type) >= OFP_DL_TYPE_ETH2_CUTOFF) {
             /* This is an Ethernet II frame */
             flow->dl_type = eth->eth_type;
@@ -104,23 +142,29 @@ flow_extract(struct buffer *packet, uint16_t in_port, struct flow *flow)
 
         packet->l3 = b.data;
         if (flow->dl_type == htons(ETH_TYPE_IP)) {
-            const struct ip_header *nh = buffer_at(&b, 0, sizeof *nh);
+            const struct ip_header *nh = pull_ip(&b);
             if (nh) {
-                int ip_len = IP_IHL(nh->ip_ihl_ver) * 4;
-                if (ip_len < IP_HEADER_LEN) {
-                    return;
-                }
-
                 flow->nw_src = nh->ip_src;
                 flow->nw_dst = nh->ip_dst;
                 flow->nw_proto = nh->ip_proto;
-                if (flow->nw_proto == IP_TYPE_TCP
-                    || flow->nw_proto == IP_TYPE_UDP) {
-                    const struct udp_header *th;
-                    th = packet->l4 = buffer_at(&b, ip_len, sizeof *th);
-                    if (th) {
-                        flow->tp_src = th->udp_src;
-                        flow->tp_dst = th->udp_dst;
+                packet->l4 = b.data;
+                if (flow->nw_proto == IP_TYPE_TCP) {
+                    const struct tcp_header *tcp = pull_tcp(&b);
+                    if (tcp) {
+                        flow->tp_src = tcp->tcp_src;
+                        flow->tp_dst = tcp->tcp_dst;
+                        packet->l7 = b.data;
+                    } else {
+                        /* Avoid tricking other code into thinking that this
+                         * packet has an L4 header. */
+                        flow->nw_proto = 0;
+                    }
+                } else if (flow->nw_proto == IP_TYPE_UDP) {
+                    const struct udp_header *udp = pull_udp(&b);
+                    if (udp) {
+                        flow->tp_src = udp->udp_src;
+                        flow->tp_dst = udp->udp_dst;
+                        packet->l7 = b.data;
                     } else {
                         /* Avoid tricking other code into thinking that this
                          * packet has an L4 header. */