Fixed a small bug in te variable info dialog.

diff --git a/NEWS b/NEWS
index 2481c82c0ab2a957b1cf60564cab3150d5713276..8ba15ffcdfdf3f5e5fddbc69abfc529292bad95a 100644 (file)
--- a/NEWS
+++ b/NEWS
@@ -17,6 +17,9 @@ Changes from 0.10.1 to 0.10.2:
    - T-test with independent samples GUI crashed with string
      type variable as group variable.
 
+   - The variable info dialog showed the previous selected variable
+     superimposed with the currently selected one.
+
 Changes from 0.10.0 to 0.10.1:
 
  * Bug fixes, including the following:

diff --git a/src/ui/gui/psppire-dialog-action-var-info.c b/src/ui/gui/psppire-dialog-action-var-info.c
index 21f9f0439ce52e8292ff2ea49eedc2198f572a2b..998f7bb45c73c6e02f92c216dc35664d2051a43e 100644 (file)
--- a/src/ui/gui/psppire-dialog-action-var-info.c
+++ b/src/ui/gui/psppire-dialog-action-var-info.c
@@ -175,28 +175,29 @@ psppire_dialog_action_var_info_activate (PsppireDialogAction *a)
     {
       xml = builder_new ("variable-info.ui");
       g_hash_table_insert (thing, a, xml);
-    }
-
-  act->output = psppire_output_view_new (
-    GTK_LAYOUT (get_widget_assert (xml, "layout1")), NULL, NULL, NULL);
 
-  pda->dialog = get_widget_assert (xml, "variable-info-dialog");
-  pda->source = get_widget_assert (xml, "treeview2");
+      act->output =
+       psppire_output_view_new (GTK_LAYOUT (get_widget_assert (xml, "layout1")),
+                                NULL, NULL, NULL);
+  
+      pda->dialog = get_widget_assert (xml, "variable-info-dialog");
+      pda->source = get_widget_assert (xml, "treeview2");
 
-  g_object_set (pda->source,
-               "selection-mode", GTK_SELECTION_MULTIPLE,
-               NULL);
+      g_object_set (pda->source,
+                   "selection-mode", GTK_SELECTION_MULTIPLE,
+                   NULL);
 
-  g_signal_connect (gtk_tree_view_get_selection (GTK_TREE_VIEW (pda->source)),
-                    "changed", G_CALLBACK (populate_output),
-                   act);
+      g_signal_connect (gtk_tree_view_get_selection (GTK_TREE_VIEW (pda->source)),
+                       "changed", G_CALLBACK (populate_output),
+                       act);
 
-  g_signal_connect (pda->dialog, "response", G_CALLBACK (jump_to),
-                   pda);
-
-  psppire_dialog_action_set_valid_predicate (pda,
-                                            treeview_item_selected);
+      g_signal_connect (pda->dialog, "response", G_CALLBACK (jump_to),
+                       pda);
 
+      psppire_dialog_action_set_valid_predicate (pda,
+                                                treeview_item_selected);
+    }
+  
   if (PSPPIRE_DIALOG_ACTION_CLASS (psppire_dialog_action_var_info_parent_class)->activate)
     PSPPIRE_DIALOG_ACTION_CLASS (psppire_dialog_action_var_info_parent_class)->activate (pda);
 }