classifier: Change cls_rule_set_nd_target() to take a pointer.

The other cls_rule_*() functions that take IPv6 addresses take a pointer
to an in6_addr, so cls_rule_set_nd_target() should as well for consistency.
Possibly this is more efficient also, although I guess it doesn't really
make much of a difference either way.

diff --git a/lib/classifier.c b/lib/classifier.c
index d1f9d5ddc0336a549786804226bbbe5b97237719..fef4014d0868f4ac26f9f843e5319e7227e02080 100644 (file)
--- a/lib/classifier.c
+++ b/lib/classifier.c
@@ -390,10 +390,10 @@ cls_rule_set_ipv6_dst_masked(struct cls_rule *rule, const struct in6_addr *dst,
 }
 
 void
-cls_rule_set_nd_target(struct cls_rule *rule, const struct in6_addr target)
+cls_rule_set_nd_target(struct cls_rule *rule, const struct in6_addr *target)
 {
     rule->wc.wildcards &= ~FWW_ND_TARGET;
-    rule->flow.nd_target = target;
+    rule->flow.nd_target = *target;
 }
 
 /* Returns true if 'a' and 'b' have the same priority, wildcard the same

diff --git a/lib/classifier.h b/lib/classifier.h
index 0dfb1e7f746e33f1d71d21de6c81d085c8a3ae57..20b95909f7f2481112b2467203d5e3626ac91d0f 100644 (file)
--- a/lib/classifier.h
+++ b/lib/classifier.h
@@ -115,7 +115,7 @@ bool cls_rule_set_ipv6_src_masked(struct cls_rule *, const struct in6_addr *,
 void cls_rule_set_ipv6_dst(struct cls_rule *, const struct in6_addr *);
 bool cls_rule_set_ipv6_dst_masked(struct cls_rule *, const struct in6_addr *,
                                   const struct in6_addr *);
-void cls_rule_set_nd_target(struct cls_rule *, const struct in6_addr);
+void cls_rule_set_nd_target(struct cls_rule *, const struct in6_addr *);
 
 bool cls_rule_equal(const struct cls_rule *, const struct cls_rule *);
 uint32_t cls_rule_hash(const struct cls_rule *, uint32_t basis);

diff --git a/lib/ofp-parse.c b/lib/ofp-parse.c
index e352bd436334b823fac85dfbe97efb3419ab4913..2d4f0119938227c2cef06bdb9a091e83a762cee8 100644 (file)
--- a/lib/ofp-parse.c
+++ b/lib/ofp-parse.c
@@ -813,7 +813,7 @@ parse_field_value(struct cls_rule *rule, enum field_index index,
 
     case F_ND_TARGET:
         str_to_ipv6(value, &ipv6, NULL);
-        cls_rule_set_nd_target(rule, ipv6);
+        cls_rule_set_nd_target(rule, &ipv6);
         break;
 
     case F_ND_SLL: