Override open more carefully.

diff --git a/ChangeLog b/ChangeLog
index 53789ebdc586c86da52c547e9d9757c5f4f7e112..d56488efa8797ee68c299927f0af096a8ee4839a 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,12 @@
 2008-09-28  Bruno Haible  <bruno@clisp.org>
 
+       Override open more carefully.
+       * lib/open.c (orig_open): New function.
+       (rpl_open): Use orig_open instead of open.
+       * lib/fcntl.in.h: Add special invocation convention.
+       * m4/open.m4 (gl_PREREQ_OPEN): New macro.
+       (gl_FUNC_OPEN): Invoke it.
+
        Override freopen more carefully.
        * lib/freopen.c (orig_freopen): New function.
        (rpl_freopen): Use orig_freopen instead of freopen.

diff --git a/lib/fcntl.in.h b/lib/fcntl.in.h
index 278f2039f4574c2c1c926c5634664be5964c9785..79b8f165f8e0e823db84dfcfd637d6f62339acc6 100644 (file)
--- a/lib/fcntl.in.h
+++ b/lib/fcntl.in.h
@@ -17,10 +17,21 @@
 
 /* written by Paul Eggert */
 
-#ifndef _GL_FCNTL_H
-
 @PRAGMA_SYSTEM_HEADER@
 
+#if defined __need_system_fcntl_h
+/* Special invocation convention.  */
+
+#include <sys/types.h>
+#include <sys/stat.h>
+#include <unistd.h>
+#@INCLUDE_NEXT@ @NEXT_FCNTL_H@
+
+#else
+/* Normal invocation convention.  */
+
+#ifndef _GL_FCNTL_H
+
 #include <sys/types.h>
 #include <sys/stat.h>
 #include <unistd.h>
@@ -121,3 +132,4 @@ extern int open (const char *filename, int flags, ...);
 
 #endif /* _GL_FCNTL_H */
 #endif /* _GL_FCNTL_H */
+#endif

diff --git a/lib/open.c b/lib/open.c
index 97c30cee8c60ed5aa20bea42b64587caedb80d4f..9a35f5b2a6add92db03e40da7b7c63a70f0d894a 100644 (file)
--- a/lib/open.c
+++ b/lib/open.c
@@ -18,6 +18,18 @@
 
 #include <config.h>
 
+/* Get the original definition of open.  It might be defined as a macro.  */
+#define __need_system_fcntl_h
+#include <fcntl.h>
+#undef __need_system_fcntl_h
+#include <sys/types.h>
+
+static inline int
+orig_open (const char *filename, int flags, mode_t mode)
+{
+  return open (filename, flags, mode);
+}
+
 /* Specification.  */
 #include <fcntl.h>
 
@@ -32,7 +44,6 @@
 
 int
 open (const char *filename, int flags, ...)
-# undef open
 {
   mode_t mode;
   int fd;
@@ -91,7 +102,7 @@ open (const char *filename, int flags, ...)
     }
 # endif
 
-  fd = open (filename, flags, mode);
+  fd = orig_open (filename, flags, mode);
 
 # if OPEN_TRAILING_SLASH_BUG
   /* If the filename ends in a slash and fd does not refer to a directory,

diff --git a/m4/open.m4 b/m4/open.m4
index 335f4e500d69f0ae31dd0371336508f40a7a52fe..fab0ad987abbf23e8766350aded5b46fe9a48bca 100644 (file)
--- a/m4/open.m4
+++ b/m4/open.m4
@@ -1,4 +1,4 @@
-# open.m4 serial 2
+# open.m4 serial 3
 dnl Copyright (C) 2007-2008 Free Software Foundation, Inc.
 dnl This file is free software; the Free Software Foundation
 dnl gives unlimited permission to copy and/or distribute it,
@@ -45,8 +45,15 @@ changequote([,])dnl
             [Define to 1 if open() fails to recognize a trailing slash.])
           REPLACE_OPEN=1
           AC_LIBOBJ([open])
+          gl_PREREQ_OPEN
           ;;
       esac
       ;;
   esac
 ])
+
+# Prerequisites of lib/open.c.
+AC_DEFUN([gl_PREREQ_OPEN],
+[
+  AC_REQUIRE([AC_C_INLINE])
+])