pipe2: Simplify code.

* lib/pipe2.c (pipe2): Reduce code duplication.

diff --git a/ChangeLog b/ChangeLog
index 1f09ff84580f69088eb2a3222313b86dd76d845b..c5e07aa078af5632f46aba1f3faa9fced017d825 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2011-04-17  Bruno Haible  <bruno@clisp.org>
+
+       pipe2: Simplify code.
+       * lib/pipe2.c (pipe2): Reduce code duplication.
+
 2011-04-17  Bruno Haible  <bruno@clisp.org>
 
        nonblocking: Add comment.

diff --git a/lib/pipe2.c b/lib/pipe2.c
index 6ffb101f3d0ce6cdac672b2733a31ad631834257..18098c4b4ec93e8e624216dff2ba983709a7eaf7 100644 (file)
--- a/lib/pipe2.c
+++ b/lib/pipe2.c
@@ -66,23 +66,17 @@ pipe2 (int fd[2], int flags)
 #if (defined _WIN32 || defined __WIN32__) && ! defined __CYGWIN__
 /* Native Woe32 API.  */
 
+  if (_pipe (fd, 4096, flags & ~O_NONBLOCK) < 0)
+    return -1;
+
   if (flags & O_NONBLOCK)
     {
-      int result = _pipe (fd, 4096, flags & ~O_NONBLOCK);
-      if (result != 0)
-        return result;
       if (set_nonblocking_flag (fd[0], true) != 0
           || set_nonblocking_flag (fd[1], true) != 0)
-        {
-          int saved_errno = errno;
-          close (fd[0]);
-          close (fd[1]);
-          result = -1;
-          errno = saved_errno;
-        }
-      return result;
+        goto fail;
     }
-  return _pipe (fd, 4096, flags);
+
+  return 0;
 
 #else
 /* Unix API.  */
@@ -131,6 +125,8 @@ pipe2 (int fd[2], int flags)
 
   return 0;
 
+#endif
+
  fail:
   {
     int saved_errno = errno;
@@ -139,6 +135,4 @@ pipe2 (int fd[2], int flags)
     errno = saved_errno;
     return -1;
   }
-
-#endif
 }