vswitchd: Fix svec_diff().

The logic bugs here were causing bridge.c to do too much work adding and
deleting interfaces unnecessarily and perhaps in some circumstances getting
the set of interfaces wrong entirely.

diff --git a/lib/svec.c b/lib/svec.c
index bb58408ee3ff643c0ef65402d1379efc9217bfa3..59d806cf37a6e542217c026e3ef494ece280d64e 100644 (file)
--- a/lib/svec.c
+++ b/lib/svec.c
@@ -148,12 +148,12 @@ svec_diff(const struct svec *a, const struct svec *b,
     }
     for (i = j = 0; i < a->n && j < b->n; ) {
         int cmp = strcmp(a->names[i], b->names[j]);
-        if (cmp > 0) {
+        if (cmp < 0) {
             if (a_only) {
                 svec_add(a_only, a->names[i]);
             }
             i++;
-        } else if (cmp < 0) {
+        } else if (cmp > 0) {
             if (b_only) {
                 svec_add(b_only, b->names[j]);
             }