tests: drop unused link dependency

Ever since commit 2392b18099, openat and fdopendir no longer drag in
xalloc-die through indirect dependencies, so these tests no longer
need $(LIBINTL).

* modules/areadlinkat-tests (Makefile.am): Drop stale LDADD.
* modules/dirent-safer-tests (Makefile.am): Likewise.
* modules/fdopendir-tests (Makefile.am): Likewise.
* modules/mkfifoat-tests (Makefile.am): Likewise.
* modules/openat-safer-tests (Makefile.am): Likewise.
* modules/openat-tests (Makefile.am): Likewise.
* modules/readlinkat-tests (Makefile.am): Likewise.
* modules/symlinkat-tests (Makefile.am): Likewise.
* modules/linkat-tests (Makefile.am): Likewise.
(Depends-on): Switch to filenamecat-lgpl.
* modules/fdutimensat-tests (test_fdutimensat_LDADD): Drop unused
LIBINTL.
* modules/utimensat-tests (test_utimensat_LDADD): Likewise.
* tests/test-linkat.c (main): Don't require xalloc.

Signed-off-by: Eric Blake <eblake@redhat.com>

diff --git a/ChangeLog b/ChangeLog
index df91f2583dd86480ff066d897bbc3731da069809..654d5c0594ee318c761c4d9e49c086397e38cb57 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,21 @@
 2011-04-28  Eric Blake  <eblake@redhat.com>
 
+       tests: drop unused link dependency
+       * modules/areadlinkat-tests (Makefile.am): Drop stale LDADD.
+       * modules/dirent-safer-tests (Makefile.am): Likewise.
+       * modules/fdopendir-tests (Makefile.am): Likewise.
+       * modules/mkfifoat-tests (Makefile.am): Likewise.
+       * modules/openat-safer-tests (Makefile.am): Likewise.
+       * modules/openat-tests (Makefile.am): Likewise.
+       * modules/readlinkat-tests (Makefile.am): Likewise.
+       * modules/symlinkat-tests (Makefile.am): Likewise.
+       * modules/linkat-tests (Makefile.am): Likewise.
+       (Depends-on): Switch to filenamecat-lgpl.
+       * modules/fdutimensat-tests (test_fdutimensat_LDADD): Drop unused
+       LIBINTL.
+       * modules/utimensat-tests (test_utimensat_LDADD): Likewise.
+       * tests/test-linkat.c (main): Don't require xalloc.
+
        hash, mgetgroups: drop xalloc dependency
        * lib/hash.c (includes): Adjust includes.
        * lib/mgetgroups.c (includes): Likewise.

diff --git a/modules/areadlinkat-tests b/modules/areadlinkat-tests
index 422ac61412c96668c9857c098b4a069dba635f43..23e527848645de94bb3966db62699ec05f7e173e 100644 (file)
--- a/modules/areadlinkat-tests
+++ b/modules/areadlinkat-tests
@@ -13,4 +13,3 @@ configure.ac:
 Makefile.am:
 TESTS += test-areadlinkat
 check_PROGRAMS += test-areadlinkat
-test_areadlinkat_LDADD = $(LDADD) @LIBINTL@

diff --git a/modules/dirent-safer-tests b/modules/dirent-safer-tests
index 172c662de407de2b34a7818bf4fe323aa93205a8..2bc95933fdb6293d4dae2c07d28565b77aeff3e3 100644 (file)
--- a/modules/dirent-safer-tests
+++ b/modules/dirent-safer-tests
@@ -10,6 +10,3 @@ configure.ac:
 Makefile.am:
 TESTS += test-dirent-safer
 check_PROGRAMS += test-dirent-safer
-# Link with libintl when needed. dirent-safer uses fdopendir if it is present,
-# and fdopendir indirectly depends on xgetcwd -> xalloc-die -> gettext-h.
-test_dirent_safer_LDADD = $(LDADD) $(LIBINTL)

diff --git a/modules/fdopendir-tests b/modules/fdopendir-tests
index bee2df7df5265682c93a916c31b1202b9cb33cb0..39575ba3f07f8d73fcb6afddc19b6c4afc77e8e1 100644 (file)
--- a/modules/fdopendir-tests
+++ b/modules/fdopendir-tests
@@ -12,4 +12,3 @@ configure.ac:
 Makefile.am:
 TESTS += test-fdopendir
 check_PROGRAMS += test-fdopendir
-test_fdopendir_LDADD = $(LDADD) @LIBINTL@

diff --git a/modules/fdutimensat-tests b/modules/fdutimensat-tests
index 48ea78d23325590370cfa72c9dc576bda335265b..1d107ce5c1d5fd5a4d557a7538ba8a5932a1e024 100644 (file)
--- a/modules/fdutimensat-tests
+++ b/modules/fdutimensat-tests
@@ -19,4 +19,4 @@ configure.ac:
 Makefile.am:
 TESTS += test-fdutimensat
 check_PROGRAMS += test-fdutimensat
-test_fdutimensat_LDADD = $(LDADD) $(LIB_CLOCK_GETTIME) @LIBINTL@
+test_fdutimensat_LDADD = $(LDADD) $(LIB_CLOCK_GETTIME)

diff --git a/modules/linkat-tests b/modules/linkat-tests
index c49c1b324a57deb7fd0922cf28489e9ecc6d8f45..3f2d3f090ca36aebf5ae3378e70e6ae7419af358 100644 (file)
--- a/modules/linkat-tests
+++ b/modules/linkat-tests
@@ -7,7 +7,7 @@ tests/macros.h
 Depends-on:
 ignore-value
 areadlink-with-size
-filenamecat
+filenamecat-lgpl
 getcwd-lgpl
 progname
 same-inode
@@ -17,4 +17,3 @@ configure.ac:
 Makefile.am:
 TESTS += test-linkat
 check_PROGRAMS += test-linkat
-test_linkat_LDADD = $(LDADD) @LIBINTL@

diff --git a/modules/mkfifoat-tests b/modules/mkfifoat-tests
index 8be33df05dd1f777a2f1323d234f533c435f232c..a1e33c98128c0fa0e981a6efb1c71ef0d29da817 100644 (file)
--- a/modules/mkfifoat-tests
+++ b/modules/mkfifoat-tests
@@ -13,4 +13,3 @@ configure.ac:
 Makefile.am:
 TESTS += test-mkfifoat
 check_PROGRAMS += test-mkfifoat
-test_mkfifoat_LDADD = $(LDADD) @LIBINTL@

diff --git a/modules/openat-safer-tests b/modules/openat-safer-tests
index 1f0b158fc0634dc4fc91cd84347126c4a5fa0ad3..a33d2c6b680ea77fbd81e71a3e0eced74a10bcbb 100644 (file)
--- a/modules/openat-safer-tests
+++ b/modules/openat-safer-tests
@@ -9,4 +9,3 @@ configure.ac:
 Makefile.am:
 TESTS += test-openat-safer
 check_PROGRAMS += test-openat-safer
-test_openat_safer_LDADD = $(LDADD) @LIBINTL@

diff --git a/modules/openat-tests b/modules/openat-tests
index 250a574593509d5e56d22ac1c1ffe65bfc1d2c60..959d8823336afe37ad64a05b3aa810b0e92412ce 100644 (file)
--- a/modules/openat-tests
+++ b/modules/openat-tests
@@ -31,8 +31,3 @@ Makefile.am:
 TESTS += test-fchownat test-fstatat test-mkdirat test-openat test-unlinkat
 check_PROGRAMS += test-fchownat test-fstatat test-mkdirat test-openat \
   test-unlinkat
-test_fchownat_LDADD = $(LDADD) @LIBINTL@
-test_fstatat_LDADD = $(LDADD) @LIBINTL@
-test_mkdirat_LDADD = $(LDADD) @LIBINTL@
-test_openat_LDADD = $(LDADD) @LIBINTL@
-test_unlinkat_LDADD = $(LDADD) @LIBINTL@

diff --git a/modules/readlinkat-tests b/modules/readlinkat-tests
index de23df8ddec34e01ee317928faf6665858904a5c..96faa5699bf712343798aac8b049fd7135fac5cc 100644 (file)
--- a/modules/readlinkat-tests
+++ b/modules/readlinkat-tests
@@ -13,4 +13,3 @@ configure.ac:
 Makefile.am:
 TESTS += test-readlinkat
 check_PROGRAMS += test-readlinkat
-test_readlinkat_LDADD = $(LDADD) @LIBINTL@

diff --git a/modules/symlinkat-tests b/modules/symlinkat-tests
index 90331494a4dc5d44f5907b41707fbd423786932d..13ae9bd8a11d3200f10e1a4ac4dc2fbeb78fdc19 100644 (file)
--- a/modules/symlinkat-tests
+++ b/modules/symlinkat-tests
@@ -12,4 +12,3 @@ configure.ac:
 Makefile.am:
 TESTS += test-symlinkat
 check_PROGRAMS += test-symlinkat
-test_symlinkat_LDADD = $(LDADD) @LIBINTL@

diff --git a/modules/utimensat-tests b/modules/utimensat-tests
index 26dbac6762ef39eae709d02345b941e7b23d3b5e..987a86abc523fb3e13aec577986aa2ed0eccdb0f 100644 (file)
--- a/modules/utimensat-tests
+++ b/modules/utimensat-tests
@@ -19,4 +19,4 @@ configure.ac:
 Makefile.am:
 TESTS += test-utimensat
 check_PROGRAMS += test-utimensat
-test_utimensat_LDADD = $(LDADD) $(LIB_CLOCK_GETTIME) @LIBINTL@
+test_utimensat_LDADD = $(LDADD) $(LIB_CLOCK_GETTIME)

diff --git a/tests/test-linkat.c b/tests/test-linkat.c
index e3c8a5e1d4ab8a235623d3cd60736277bf96359a..2bf17905243af3f4cd2e543f6bb8b064d444fc45 100644 (file)
--- a/tests/test-linkat.c
+++ b/tests/test-linkat.c
@@ -140,9 +140,11 @@ main (void)
   for (i = 0; i < 32; i++)
     {
       int fd1 = (i & 8) ? dfd : AT_FDCWD;
-      char *file1 = file_name_concat ((i & 4) ? ".." : cwd, BASE "xx", NULL);
+      char *file1 = mfile_name_concat ((i & 4) ? ".." : cwd, BASE "xx", NULL);
       int fd2 = (i & 2) ? dfd : AT_FDCWD;
-      char *file2 = file_name_concat ((i & 1) ? ".." : cwd, BASE "xx", NULL);
+      char *file2 = mfile_name_concat ((i & 1) ? ".." : cwd, BASE "xx", NULL);
+      ASSERT (file1);
+      ASSERT (file2);
       flag = (i & 0x10 ? AT_SYMLINK_FOLLOW : 0);
 
       ASSERT (sprintf (strchr (file1, '\0') - 2, "%02d", i) == 2);