projects
/
openvswitch
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
3603f8d
)
ovs-vsctl: Print correct fail-mode
author
Justin Pettit
<jpettit@nicira.com>
Tue, 12 Jan 2010 00:57:29 +0000
(16:57 -0800)
committer
Justin Pettit
<jpettit@nicira.com>
Tue, 12 Jan 2010 01:07:19 +0000
(17:07 -0800)
When printing the fail-mode, ovs-vsctl would always attempt to print the
top-level one--even if it didn't exist. So, in addition to sometimes
being wrong, it could cause segfaults.
Thanks to Peter Balland for reporting the error.
Bug #2374
utilities/ovs-vsctl.c
patch
|
blob
|
history
diff --git
a/utilities/ovs-vsctl.c
b/utilities/ovs-vsctl.c
index 3a73a2321ae27e33dc726e07c517641693a7ddd2..725988a5dc026662ae8e94ca42604948e38e1255 100644
(file)
--- a/
utilities/ovs-vsctl.c
+++ b/
utilities/ovs-vsctl.c
@@
-1345,7
+1345,7
@@
cmd_get_fail_mode(struct vsctl_context *ctx)
}
if (fail_mode && strlen(fail_mode)) {
- ds_put_format(&ctx->output, "%s\n",
info.ctrl->
fail_mode);
+ ds_put_format(&ctx->output, "%s\n", fail_mode);
}
free_info(&info);