Improve lseek module.

* lib/lseek.c (rpl_lseek): Detect EBADF on mingw.
* lib/unistd_.h (lseek): Scale back link warning message.
* tests/test-lseek.c: Beef up test.
* tests/test-lseek.sh: Exercise more facets of lseek.
Reported by Bruno Haible.

diff --git a/ChangeLog b/ChangeLog
index 91eb8d1f3e983924546bb25f05a47b7eb28e3b0d..253ae37b668e2dbd5e9f5544744f57c588965dad 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,12 @@
+2007-05-28  Eric Blake  <ebb9@byu.net>
+
+       Improve lseek module.
+       * lib/lseek.c (rpl_lseek): Detect EBADF on mingw.
+       * lib/unistd_.h (lseek): Scale back link warning message.
+       * tests/test-lseek.c: Beef up test.
+       * tests/test-lseek.sh: Exercise more facets of lseek.
+       Reported by Bruno Haible.
+
 2007-05-28  Bruno Haible  <bruno@clisp.org>
 
        * tests/test-unistd.c: Test all the types that <unistd.h> is expected

diff --git a/lib/lseek.c b/lib/lseek.c
index 3d2fd42eb4e8857acfd70bd6747df5e1ce5b6e37..03830a9acdf9cbf9a4e3353ec06ecf51a4c960a6 100644 (file)
--- a/lib/lseek.c
+++ b/lib/lseek.c
@@ -31,7 +31,13 @@ off_t
 rpl_lseek (int fd, off_t offset, int whence)
 {
   /* mingw lseek mistakenly succeeds on pipes, sockets, and terminals.  */
-  if (GetFileType ((HANDLE) _get_osfhandle (fd)) != FILE_TYPE_DISK)
+  HANDLE h = (HANDLE) _get_osfhandle (fd);
+  if (h == INVALID_HANDLE_VALUE)
+    {
+      errno = EBADF;
+      return -1;
+    }
+  if (GetFileType (h) != FILE_TYPE_DISK)
     {
       errno = ESPIPE;
       return -1;

diff --git a/lib/unistd_.h b/lib/unistd_.h
index da165c5bfff934b15eacdf883d017b45b43feccd..ad1b265f49f3d526a7c3be47596c88744dc3b4af 100644 (file)
--- a/lib/unistd_.h
+++ b/lib/unistd_.h
@@ -188,9 +188,8 @@ extern int getlogin_r (char *name, size_t size);
 #elif defined GNULIB_POSIXCHECK
 # undef lseek
 # define lseek(f,o,w) \
-    (GL_LINK_WARNING ("lseek does not fail with ESPIPE on non-seekable " \
-                      "files on some systems - " \
-                      "use gnulib module lseek for portability"), \
+    (GL_LINK_WARNING ("lseek does not fail with ESPIPE on pipes on some " \
+                      "systems - use gnulib module lseek for portability"), \
      lseek (f, o, w))
 #endif
 

diff --git a/tests/test-lseek.c b/tests/test-lseek.c
index ae53d98cad58530d02169c7bea2ca27cb9b3a6ab..d70629e1cd869996a62ba1987312c0ab3a06159e 100644 (file)
--- a/tests/test-lseek.c
+++ b/tests/test-lseek.c
@@ -19,11 +19,69 @@
 
 #include <config.h>
 
+#include <errno.h>
+#include <stdio.h>
 #include <unistd.h>
 
+#define ASSERT(expr) \
+  do                                                                        \
+    {                                                                       \
+      if (!(expr))                                                          \
+        {                                                                   \
+          fprintf (stderr, "%s:%d: assertion failed\n", __FILE__, __LINE__); \
+          abort ();                                                         \
+        }                                                                   \
+    }                                                                       \
+  while (0)
+
+/* ARGC must be 2; *ARGV[1] is '0' if stdin and stdout are files, '1'
+   if they are pipes, and '2' if they are closed.  Check for proper
+   semantics of lseek.  */
 int
-main ()
+main (int argc, char **argv)
 {
-  /* Exit with success only if stdin is seekable.  */
-  return lseek (0, (off_t)0, SEEK_CUR) < 0;
+  if (argc != 2)
+    return 2;
+  switch (*argv[1])
+    {
+    case '0': /* regular files */
+      ASSERT (lseek (0, (off_t)2, SEEK_SET) == 2);
+      ASSERT (lseek (0, (off_t)-4, SEEK_CUR) == -1);
+      ASSERT (errno == EINVAL);
+      errno = 0;
+      ASSERT (lseek (0, (off_t)0, SEEK_CUR) == 2);
+      ASSERT (lseek (0, (off_t)0, (SEEK_SET | SEEK_CUR | SEEK_END) + 1) == -1);
+      ASSERT (errno == EINVAL);
+      ASSERT (lseek (1, (off_t)2, SEEK_SET) == 2);
+      errno = 0;
+      ASSERT (lseek (1, (off_t)-4, SEEK_CUR) == -1);
+      ASSERT (errno == EINVAL);
+      errno = 0;
+      ASSERT (lseek (1, (off_t)0, SEEK_CUR) == 2);
+      ASSERT (lseek (1, (off_t)0, (SEEK_SET | SEEK_CUR | SEEK_END) + 1) == -1);
+      ASSERT (errno == EINVAL);
+      break;
+
+    case '1': /* pipes */
+      errno = 0;
+      ASSERT (lseek (0, (off_t)0, SEEK_CUR) == -1);
+      ASSERT (errno == ESPIPE);
+      errno = 0;
+      ASSERT (lseek (1, (off_t)0, SEEK_CUR) == -1);
+      ASSERT (errno == ESPIPE);
+      break;
+
+    case '2': /* closed */
+      errno = 0;
+      ASSERT (lseek (0, (off_t)0, SEEK_CUR) == -1);
+      ASSERT (errno == EBADF);
+      errno = 0;
+      ASSERT (lseek (1, (off_t)0, SEEK_CUR) == -1);
+      ASSERT (errno == EBADF);
+      break;
+
+    default:
+      return 1;
+    }
+  return 0;
 }

diff --git a/tests/test-lseek.sh b/tests/test-lseek.sh
index 966dd2e89b3cd7b07dcced348723f5c5ffb5c6a5..e84c2bb49347fa3403142fb3d737bc4331183902 100755 (executable)
--- a/tests/test-lseek.sh
+++ b/tests/test-lseek.sh
@@ -1,7 +1,17 @@
 #!/bin/sh
 
-# Succeed on seekable stdin
-./test-lseek${EXEEXT} < "$srcdir/test-lseek.sh" || exit 1
-# Fail on pipe stdin
-echo hi | ./test-lseek${EXEEXT} && exit 1
+tmpfiles=
+trap 'rm -fr $tmpfiles' 1 2 3 15
+
+tmpfiles=t-lseek.tmp
+# seekable files
+./test-lseek${EXEEXT} 0 < "$srcdir/test-lseek.sh" > t-lseek.tmp || exit 1
+
+# pipes
+echo hi | ./test-lseek${EXEEXT} 1 | cat || exit 1
+
+# closed descriptors
+./test-lseek${EXEEXT} 2 <&- >&- || exit 1
+
+rm -rf $tmpfiles
 exit 0