projects
/
openvswitch
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
027f900
)
ofp-parse: ofp-parse fails to properly validate DROP.
author
Ethan Jackson
<ethan@nicira.com>
Sun, 2 Jan 2011 20:52:11 +0000
(12:52 -0800)
committer
Ethan Jackson
<ethan@nicira.com>
Sun, 2 Jan 2011 21:17:05 +0000
(13:17 -0800)
The str_to_action function of ofp-parse was not properly
incrementing it's actions counter. Thus it did not enforce the
requirement that DROP actions not be preceded by other actions.
lib/ofp-parse.c
patch
|
blob
|
history
diff --git
a/lib/ofp-parse.c
b/lib/ofp-parse.c
index e30c8a91a2ea1878629265109aaf01af5184774e..f8464b99d7fbde5f96cecb86e1776b8d6679810a 100644
(file)
--- a/
lib/ofp-parse.c
+++ b/
lib/ofp-parse.c
@@
-200,6
+200,7
@@
str_to_action(char *str, struct ofpbuf *b)
char *pos;
pos = str;
+ n_actions = 0;
for (;;) {
char *act, *arg;
size_t actlen;
@@
-414,6
+415,7
@@
str_to_action(char *str, struct ofpbuf *b)
} else {
ovs_fatal(0, "Unknown action: %s", act);
}
+ n_actions++;
}
}