(mode_compile): Use uintmax_t, not unsigned

long, to parse numeric modes.  Check for any unknown bits, not
just unknown bits left of the leftmost known bit.

diff --git a/lib/modechange.c b/lib/modechange.c
index 71432fa427bbd782acc239d240a399f7e6f99cc5..fda84c90aad9be8d1db5c9fa9302dd2f7f5268ab 100644 (file)
--- a/lib/modechange.c
+++ b/lib/modechange.c
@@ -1,5 +1,5 @@
 /* modechange.c -- file mode manipulation
-   Copyright (C) 1989, 1990, 1997, 1998, 1999 Free Software Foundation, Inc.
+   Copyright (C) 1989, 1990, 1997-2000 Free Software Foundation, Inc.
 
    This program is free software; you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
@@ -157,7 +157,7 @@ mode_compile (const char *mode_string, unsigned int masked_ops)
 {
   struct mode_change *head;    /* First element of the linked list. */
   struct mode_change *tail;    /* An element of the linked list. */
-  unsigned long mode_value;    /* The mode value, if octal.  */
+  uintmax_t mode_value;                /* The mode value, if octal.  */
   char *string_end;            /* Pointer to end of parsed value.  */
   mode_t umask_value;          /* The umask value (surprise). */
 
@@ -166,10 +166,10 @@ mode_compile (const char *mode_string, unsigned int masked_ops)
   tail = NULL;
 #endif
 
-  if (xstrtoul (mode_string, &string_end, 8, &mode_value, "") == LONGINT_OK)
+  if (xstrtoumax (mode_string, &string_end, 8, &mode_value, "") == LONGINT_OK)
     {
       struct mode_change *p;
-      if (mode_value > CHMOD_MODE_BITS)
+      if (mode_value != (mode_value & CHMOD_MODE_BITS))
        return MODE_INVALID;
       p = make_node_op_equals ((mode_t) mode_value);
       if (p == NULL)