warnings: Improve code.

diff --git a/ChangeLog b/ChangeLog
index 61cd8fa63941faa84ceb49fd9eae6390ebaecc30..8ae6063901c234e987bb54be799ca7dc851fbf9b 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2008-11-17  Simon Josefsson  <simon@josefsson.org>
+
+       * m4/warnings.m4: Improve code.  Reported by Ralf Wildenhues
+       <Ralf.Wildenhues@gmx.de> and Paolo Bonzini <bonzini@gnu.org>.
+
 2008-11-17  Simon Josefsson  <simon@josefsson.org>
 
        * m4/warnings.m4: Use CPPFLAGS to really check whether the

diff --git a/m4/warnings.m4 b/m4/warnings.m4
index 686d8c7e0712afddf7930dfd80c540dc0ecdc0f4..3585c3eebcb2de1b2a3dad004b2aba5b97f43927 100644 (file)
--- a/m4/warnings.m4
+++ b/m4/warnings.m4
@@ -114,16 +114,17 @@ AC_DEFUN([gl_WARN_SUPPORTED],
 # does OUTVAR = LISTVAR \ REMOVEVAR.
 AC_DEFUN([gl_WARN_COMPLEMENT],
 [
-  FOO=
-  set -- "$2"
-  for w in $_; do
-    case "$3" in
-      *" $w "* | *" $w" | "$w "*)
+  gl_warn_set=
+  set x $2; shift
+  for gl_warn_item
+  do
+    case " $3 " in
+      *" $gl_warn_item "*)
         ;;
       *)
-        FOO="$FOO $w"
+        gl_warn_set="$gl_warn_set $gl_warn_item"
         ;;
     esac
   done
-  $1=$FOO
+  $1=$gl_warn_set
 ])