getopt: silence clang warning

http://sourceware.org/bugzilla/show_bug.cgi?id=12922

Only triggered by a program that uses "W;" in the short opt string
without providing a longopts array; that can be argued to be a
programmer error, so gnulib won't bother replacing glibc getopt if
it has that bug.

* lib/getopt.c (_getopt_internal_r): Avoid unlikely NULL
dereference.
Reported by Gustavo Martin Domato.

Signed-off-by: Eric Blake <eblake@redhat.com>

diff --git a/ChangeLog b/ChangeLog
index 2663e3246f25b5a1cfdac751f175f1c4183b91c4..8ca76fab7ad9b9bce9df2b6224294a4254505b76 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2011-06-22  Eric Blake  <eblake@redhat.com>
+
+       getopt: silence clang warning
+       * lib/getopt.c (_getopt_internal_r): Avoid unlikely NULL
+       dereference.
+       Reported by Gustavo Martin Domato.
+
 2011-06-22  Jim Meyering  <meyering@redhat.com>
 
        bootstrap: do not insert a blank line into each .gitignore file

diff --git a/lib/getopt.c b/lib/getopt.c
index 23510d8afec30de37e89f7d3eeca72854cd6f57e..2af8352ee9c93ba7d19e0c8e34fd37306332b885 100644 (file)
--- a/lib/getopt.c
+++ b/lib/getopt.c
@@ -829,7 +829,7 @@ _getopt_internal_r (int argc, char **argv, const char *optstring,
         return '?';
       }
     /* Convenience. Treat POSIX -W foo same as long option --foo */
-    if (temp[0] == 'W' && temp[1] == ';')
+    if (temp[0] == 'W' && temp[1] == ';' && longopts)
       {
         char *nameend;
         const struct option *p;