maint.mk: make "check" depend on public-submodule-commit by default

* top/maint.mk (GL_PUBLIC_SUBMODULE_COMMIT): New overridable variable.

diff --git a/ChangeLog b/ChangeLog
index 8ac17f98b09851633ef01902afb05d5f0e14a2d8..be6a9edc86a21111f5cbc83ba96877af09f08f74 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2011-01-20  Jim Meyering  <meyering@redhat.com>
+
+       maint.mk: make "check" depend on public-submodule-commit by default
+       * top/maint.mk (GL_PUBLIC_SUBMODULE_COMMIT): New overridable variable.
+
 2011-01-20  Bruno Haible  <bruno@clisp.org>
 
        mbfile, mbiter: Complete change from 2008-12-21.

diff --git a/top/maint.mk b/top/maint.mk
index 25f4736a3b42eb74cc1919ed32c74e53d7a4b526..c57acd345859405112aebf542ce606dc726b5d06 100644 (file)
--- a/top/maint.mk
+++ b/top/maint.mk
@@ -1134,6 +1134,14 @@ public-submodule-commit:
        else                                                            \
          : ;                                                           \
        fi
+# This rule has a high enough utility/cost ratio that it should be a
+# dependent of "check" by default.  However, some of us do occasionally
+# commit a temporary change that deliberately points to a non-public
+# submodule commit, and want to be able to use rules like "make check".
+# In that case, run e.g., "make check GL_PUBLIC_SUBMODULE_COMMIT="
+# to disable this test.
+GL_PUBLIC_SUBMODULE_COMMIT ?= public-submodule-commit
+check: $(GL_PUBLIC_SUBMODULE_COMMIT)
 
 .PHONY: alpha beta stable
 ALL_RECURSIVE_TARGETS += alpha beta stable