xenserver: Cope gracefully with non-integer MTU in interface-reconfigure.
authorIan Campbell <Ian.Campbell@citrix.com>
Thu, 6 Aug 2009 20:39:24 +0000 (13:39 -0700)
committerBen Pfaff <blp@nicira.com>
Fri, 7 Aug 2009 00:07:18 +0000 (17:07 -0700)
CP-1148.

xenserver/opt_xensource_libexec_interface-reconfigure

index 72d438606f982da1a96c30d1fe2fb9610c116cd6..5f19ff3684463927fca57bb10d2e570b39a35be8 100755 (executable)
@@ -758,12 +758,13 @@ def configure_netdev(pif):
     else:
         raise Error("Unknown IP-configuration-mode %s" % pifrec['ip_configuration_mode'])
 
-    oc = {}
-    if pifrec.has_key('other_config'):
-        oc = pifrec['other_config']
-        if oc.has_key('mtu'):
+    oc = pifrec['other_config']
+    if oc.has_key('mtu'):
+        try:
             int(oc['mtu'])      # Check that the value is an integer
             ifconfig_argv += ['mtu', oc['mtu']]
+        except ValueError, x:
+            log("Invalid value for mtu = %s" % mtu)
 
     run_command(ifconfig_argv)